Add addons controlpanel #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@robgietema Could I get a sanity check on this today so that I can continue to work on during the flight home? |
robgietema
reviewed
Nov 11, 2018
src/reducers/addons/addons.js
Outdated
| loaded: false, | ||
| loading: true, | ||
| }; | ||
| case `${INSTALL_ADDON}_SUCCESS`: |
Member
There was a problem hiding this comment.
Does the INSTALL_ADDON also return the full updated list? If not then you need to split the SUCCESS cases for these 3 actions.
Pull Request Test Coverage Report for Build 2829
💛 - Coveralls |
Member
|
@esteele do you plan to continue to work on this? I'd love to see this being merged. |
nileshgulia1
force-pushed
the
add-addons-controlpanel
branch
from
f3b3e41 to
dae53d8
Compare
Member
|
@robgietema It's ready for merged in? |
Member
|
@robgietema I think its done. Can you review please? |
* master: (183 commits) Add start-backend script to makefile. Add advanced customization docs Improve formatting of README Improve the README Back to development Release 1.7.0 Put image zooming into the right place. Fix image float/left right on image tile. Add missing points for document, update general docs org Back to development Release 1.6.1 Prepare for release Fix regression on position of the add tile button Remove debug dangling logging Fix post release back to development script, by adding semver.inc helper Fix version on back to development manually Back to development Release 1.6.0 add semantic classnames externally changelog ...
Member
|
It should match the mockup: It needs a liftoff on the look and feel. This is the current state:
A container needs to be added, match as much as possible with the mockup. |
# Conflicts: # src/components/index.js # src/components/manage/Tiles/HeroImageLeft/Edit.jsx # src/components/manage/Tiles/HeroImageLeft/Edit.test.jsx # src/components/manage/Tiles/HeroImageLeft/View.jsx # src/components/manage/Tiles/HeroImageLeft/View.test.jsx # src/components/manage/Tiles/HeroImageLeft/__snapshots__/Edit.test.jsx.snap # src/components/manage/Tiles/HeroImageLeft/__snapshots__/View.test.jsx.snap # src/components/manage/Tiles/Text/Edit.jsx # src/config/Tiles.jsx
…ardless of which list it’s in.
Member
|
@esteele I just merge master here and run tests locally (which pass), and also did some tests with Volto. |
Member
|
@iFlameing todo:
|
Member
|
@iFlameing I think it's ready now. @tisto we need to release the addons branch first: then remove the branching in this PR. |
sneridagh
reviewed
May 5, 2020
sneridagh
approved these changes
May 5, 2020
iFlameing
reviewed
May 6, 2020
sneridagh
approved these changes
May 6, 2020
Closed
sneridagh
added a commit
that referenced
this pull request
May 6, 2020
* master: Back to development Release 5.5.0 Prepare for release Add addons controlpanel (#297) cypress test for table block (#1243) Removing title field from dropdown in content view (#1447) Fix changelog updated image, hero and html block cypress test (#1254) Adding cypress test for sorting in folder-content based on create field (#1419) Adding expires Label (#1420) Adding word limit into text area. (#1418) internal: Update docs Back to development Release 5.4.0 Prepare for release Forward the images and files cache headers in Volto SSR passthrough (#1445) Bump jquery from 3.4.1 to 3.5.0 (#1439)
sneridagh
added a commit
that referenced
this pull request
May 7, 2020
* master: (30 commits) Back to development Release 5.6.0 Prepare for release Loads the current object language on SSR (#1450) Add default `src` alias for addons detecting if there is a released o… (#1442) Back to development Release 5.5.0 Prepare for release Add addons controlpanel (#297) cypress test for table block (#1243) Removing title field from dropdown in content view (#1447) Fix changelog updated image, hero and html block cypress test (#1254) Adding cypress test for sorting in folder-content based on create field (#1419) Adding expires Label (#1420) Adding word limit into text area. (#1418) internal: Update docs Back to development Release 5.4.0 Prepare for release ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the addons control panel in Volto.
Refs #284.