Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addons controlpanel #297

Open
wants to merge 36 commits into
base: master
from

Conversation

@esteele
Copy link
Member

commented Nov 11, 2018

Implement the addons control panel in Volto.

Refs #284.

@esteele

This comment has been minimized.

Copy link
Member Author

commented Nov 11, 2018

@robgietema Could I get a sanity check on this today so that I can continue to work on during the flight home?

src/actions/addons/addons.js Outdated Show resolved Hide resolved
src/actions/addons/addons.js Outdated Show resolved Hide resolved
loaded: false,
loading: true,
};
case `${INSTALL_ADDON}_SUCCESS`:

This comment has been minimized.

Copy link
@robgietema

robgietema Nov 11, 2018

Member

Does the INSTALL_ADDON also return the full updated list? If not then you need to split the SUCCESS cases for these 3 actions.

@coveralls

This comment has been minimized.

Copy link

commented Nov 11, 2018

Pull Request Test Coverage Report for Build 2829

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 2821: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls
@tisto

This comment has been minimized.

Copy link
Member

commented Dec 2, 2018

@esteele do you plan to continue to work on this? I'd love to see this being merged.

@tisto tisto added this to To do in Nilesh Jan 3, 2019
@nileshgulia1 nileshgulia1 force-pushed the add-addons-controlpanel branch from f3b3e41 to dae53d8 Jan 14, 2019
@nileshgulia1 nileshgulia1 requested a review from robgietema Jan 15, 2019
@nileshgulia1

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

@robgietema It's ready for merged in?

@nileshgulia1 nileshgulia1 moved this from To do to Done in Nilesh Jan 21, 2019
@nileshgulia1

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

@robgietema I think its done. Can you review please?

@nileshgulia1 nileshgulia1 moved this from Done to In progress in Nilesh Mar 12, 2019
* master: (183 commits)
  Add start-backend script to makefile.
  Add advanced customization docs
  Improve formatting of README
  Improve the README
  Back to development
  Release 1.7.0
  Put image zooming into the right place.
  Fix image float/left right on image tile.
  Add missing points for document, update general docs org
  Back to development
  Release 1.6.1
  Prepare for release
  Fix regression on position of the add tile button
  Remove debug dangling logging
  Fix post release back to development script, by adding semver.inc helper
  Fix version on back to development manually
  Back to development
  Release 1.6.0
  add semantic classnames externally
  changelog
  ...
@sneridagh

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

It should match the mockup:
https://zpl.io/aNPJNyk

It needs a liftoff on the look and feel. This is the current state:

Screenshot 2019-03-12 at 16 44 31

A container needs to be added, match as much as possible with the mockup.

esteele added 7 commits Apr 16, 2019
# Conflicts:
#	src/components/index.js
#	src/components/manage/Tiles/HeroImageLeft/Edit.jsx
#	src/components/manage/Tiles/HeroImageLeft/Edit.test.jsx
#	src/components/manage/Tiles/HeroImageLeft/View.jsx
#	src/components/manage/Tiles/HeroImageLeft/View.test.jsx
#	src/components/manage/Tiles/HeroImageLeft/__snapshots__/Edit.test.jsx.snap
#	src/components/manage/Tiles/HeroImageLeft/__snapshots__/View.test.jsx.snap
#	src/components/manage/Tiles/Text/Edit.jsx
#	src/config/Tiles.jsx
@esteele

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

Here's the current state of the design:

Installed packages
Screen Shot 2019-04-18 at 10 41 21 AM

Mosaic has an available update, but no uninstall profile, so only the upgrade button is shown.
Screen Shot 2019-04-18 at 10 42 28 AM

Installable packages
Screen Shot 2019-04-18 at 10 42 36 AM

Installable, but does not have an uninstall profile
Screen Shot 2019-04-18 at 10 46 00 AM

esteele added 3 commits Apr 18, 2019
@esteele

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

@robgietema, @sneridagh This should be ready for review. It'll need plone/plone.restapi#556 in order to work correctly, but that's nearly done.

@rodfersou

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

@esteele I just merge master here and run tests locally (which pass), and also did some tests with Volto.
Everything looks fine here, is it okay for you to merge?

rodfersou and others added 5 commits Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Nilesh
  
In progress
7 participants
You can’t perform that action at this time.