Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addons controlpanel #297

Merged
merged 49 commits into from May 6, 2020
Merged

Add addons controlpanel #297

merged 49 commits into from May 6, 2020

Conversation

esteele
Copy link
Member

@esteele esteele commented Nov 11, 2018

Implement the addons control panel in Volto.

Refs #284.

@esteele
Copy link
Member Author

esteele commented Nov 11, 2018

@robgietema Could I get a sanity check on this today so that I can continue to work on during the flight home?

src/actions/addons/addons.js Outdated Show resolved Hide resolved
src/actions/addons/addons.js Outdated Show resolved Hide resolved
src/components/manage/Controlpanels/AddonsControlpanel.jsx Outdated Show resolved Hide resolved
src/components/manage/Controlpanels/AddonsControlpanel.jsx Outdated Show resolved Hide resolved
src/components/manage/Controlpanels/AddonsControlpanel.jsx Outdated Show resolved Hide resolved
src/components/manage/Controlpanels/AddonsControlpanel.jsx Outdated Show resolved Hide resolved
src/components/manage/Controlpanels/AddonsControlpanel.jsx Outdated Show resolved Hide resolved
loaded: false,
loading: true,
};
case `${INSTALL_ADDON}_SUCCESS`:
Copy link
Member

@robgietema robgietema Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the INSTALL_ADDON also return the full updated list? If not then you need to split the SUCCESS cases for these 3 actions.

@coveralls
Copy link

coveralls commented Nov 11, 2018

Pull Request Test Coverage Report for Build 2829

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 2821: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@tisto
Copy link
Member

tisto commented Dec 2, 2018

@esteele do you plan to continue to work on this? I'd love to see this being merged.

@tisto tisto added this to To do in Nilesh Jan 3, 2019
@nileshgulia1 nileshgulia1 requested a review from robgietema Jan 15, 2019
@nileshgulia1
Copy link
Member

nileshgulia1 commented Jan 15, 2019

@robgietema It's ready for merged in?

@nileshgulia1 nileshgulia1 moved this from To do to Done in Nilesh Jan 21, 2019
@nileshgulia1
Copy link
Member

nileshgulia1 commented Feb 8, 2019

@robgietema I think its done. Can you review please?

@nileshgulia1 nileshgulia1 moved this from Done to In progress in Nilesh Mar 12, 2019
* master: (183 commits)
  Add start-backend script to makefile.
  Add advanced customization docs
  Improve formatting of README
  Improve the README
  Back to development
  Release 1.7.0
  Put image zooming into the right place.
  Fix image float/left right on image tile.
  Add missing points for document, update general docs org
  Back to development
  Release 1.6.1
  Prepare for release
  Fix regression on position of the add tile button
  Remove debug dangling logging
  Fix post release back to development script, by adding semver.inc helper
  Fix version on back to development manually
  Back to development
  Release 1.6.0
  add semantic classnames externally
  changelog
  ...
@sneridagh
Copy link
Member

sneridagh commented Mar 12, 2019

It should match the mockup:
https://zpl.io/aNPJNyk

It needs a liftoff on the look and feel. This is the current state:

Screenshot 2019-03-12 at 16 44 31

A container needs to be added, match as much as possible with the mockup.

esteele added 7 commits Apr 16, 2019
# Conflicts:
#	src/components/index.js
#	src/components/manage/Tiles/HeroImageLeft/Edit.jsx
#	src/components/manage/Tiles/HeroImageLeft/Edit.test.jsx
#	src/components/manage/Tiles/HeroImageLeft/View.jsx
#	src/components/manage/Tiles/HeroImageLeft/View.test.jsx
#	src/components/manage/Tiles/HeroImageLeft/__snapshots__/Edit.test.jsx.snap
#	src/components/manage/Tiles/HeroImageLeft/__snapshots__/View.test.jsx.snap
#	src/components/manage/Tiles/Text/Edit.jsx
#	src/config/Tiles.jsx
@tisto tisto added this to To do in Newbie Tasks Apr 9, 2020
@tisto
Copy link
Member

tisto commented Apr 16, 2020

@iFlameing todo:

  • Rebase branch and make sure Travis passes
  • Check base functionality (install add-on / uninstall add-on)
  • Write Cypress tests (install add-on / uninstall add-on) -> use working copy support

@iFlameing iFlameing moved this from To do to In progress in Newbie Tasks Apr 16, 2020
@tisto tisto moved this from In progress to Review in Newbie Tasks May 5, 2020
@sneridagh
Copy link
Member

sneridagh commented May 5, 2020

@iFlameing I think it's ready now.

@tisto we need to release the addons branch first:
plone/plone.restapi#556

then remove the branching in this PR.

package.json Outdated Show resolved Hide resolved
Copy link
Member

@iFlameing iFlameing left a comment

I am reviewing to particular file sorry!!! for this comment.

@sneridagh sneridagh merged commit a2f0893 into master May 6, 2020
6 checks passed
Newbie Tasks automation moved this from Review to Done May 6, 2020
@sneridagh sneridagh deleted the add-addons-controlpanel branch May 6, 2020
@iFlameing iFlameing mentioned this pull request May 6, 2020
sneridagh added a commit that referenced this pull request May 6, 2020
* master:
  Back to development
  Release 5.5.0
  Prepare for release
  Add addons controlpanel (#297)
  cypress test for table block (#1243)
  Removing title field from dropdown in content view (#1447)
  Fix changelog
  updated image, hero and html block cypress test (#1254)
  Adding cypress test for sorting in folder-content based on create field (#1419)
  Adding expires Label (#1420)
  Adding word limit into text area. (#1418)
  internal: Update docs
  Back to development
  Release 5.4.0
  Prepare for release
  Forward the images and files cache headers in Volto SSR passthrough (#1445)
  Bump jquery from 3.4.1 to 3.5.0 (#1439)
sneridagh added a commit that referenced this pull request May 7, 2020
* master: (30 commits)
  Back to development
  Release 5.6.0
  Prepare for release
  Loads the current object language on SSR (#1450)
  Add default `src` alias for addons detecting if there is a released o… (#1442)
  Back to development
  Release 5.5.0
  Prepare for release
  Add addons controlpanel (#297)
  cypress test for table block (#1243)
  Removing title field from dropdown in content view (#1447)
  Fix changelog
  updated image, hero and html block cypress test (#1254)
  Adding cypress test for sorting in folder-content based on create field (#1419)
  Adding expires Label (#1420)
  Adding word limit into text area. (#1418)
  internal: Update docs
  Back to development
  Release 5.4.0
  Prepare for release
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Newbie Tasks
  
Done
Nilesh
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

8 participants