New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed 'Relevance' option not being selectable by site viewers in the search block's 'Sort on' #4213
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for volto canceled.
|
Passing run #4681 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
# Conflicts: # locales/volto.pot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffersonBledsoe LGTM, but instead of showing/hide the sort buttons I'd disable them (the Button component allows it using disabled
), to avoid the UI "jump".
What do you think?
/cc @tiberiuichim
@sneridagh Your proposal sounds good to me. |
@sneridagh Updated to have the buttons disabled rather than hidden :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a closer look now, and since we are updating the Left/Right/Top components and passing down the new prop. Wouldn't it be breaking? As it requires this update to existing shadows, if the SortOn component is changed and expects it.
@JeffersonBledsoe what happens if the prop are not passed down?
@sneridagh It should still safely fall back to the existing behaviour. I will do some more testing to verify this behaviour though! |
Changes the 'No selection' option in the 'Sort on' for the search block to instead be a selectable 'Relevance' option. If no text has been searched for, this is displayed as 'Unsorted'. Also includes the following minor changes to make the 'Relevance' option make more sense:
Screen.Recording.2023-01-03.at.5.01.49.pm.mov
Closes #4000