New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User and groups control panel #608
Conversation
…one/volto into feature-29-user-control-panel
@nileshgulia1 thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
We need it to match the look and feel in: Please, can you take care? The screens are mainly in mobile sizes, but easy to translate to big ones. For the tables, very important: make them responsive, so the overflow (if any) is hidden and scrollable horizontally. Like https://getbootstrap.com/docs/4.0/content/tables/#responsive-tables Notice the subtle shadow in the mocks, Albert to blame! BTW, also, all content area in Volto is enclosed into a Container (for responsiveness), so make sure it is. Also, I've noticed that the modal is kind of broken (it's displaced to the bottom). Thanks! |
More, the password in the field is shown in clear text. |
@nileshgulia1 thank you Nilesh! |
There are still details we have to improve. Though, the base functionality is there. Therefore I'd say we should merge now.
CHANGELOG.md
Outdated
@@ -528,6 +528,15 @@ | |||
- Drag and drop to reorder tiles @robgietema | |||
- Enhanced DraftJS AnchorLink Plugin @robgietema @sneridagh | |||
- Added the configuration required in Webpack config to load CSS modules in the project, required by DraftJS AnchorLink plugin @sneridagh | |||
* Refactor UserControlPanel add delete and add user actions @csenger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nileshgulia1 This does not seem right. Can you re-add your changelog to the latest unreleased block on the changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tisto I have added the changelog!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nileshgulia1 you still have to remove those duplicate changelog entries here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I removed the old entries now. :)
@nileshgulia1 when you merged master into your branch you introduced two new checks that are now failing on Travis:
|
a63b8c9
to
6c01077
Compare
@tisto Should I commit the result of |
@nileshgulia1 yes, please. |
@nileshgulia1 I updated the i18n. Let's see what the next build will return. |
@tisto All Green! |
@@ -26,6 +26,14 @@ msgstr "" | |||
"Preferred-Encodings: utf-8 latin1\n" | |||
"X-Is-Fallback-For: de-at de-li de-lu de-ch de-de\n" | |||
|
|||
#: components/manage/Controlpanels/UsersControlpanel | |||
msgid "ADD NEW GROUP" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nileshgulia1 the message string should not be all upper-case. You can make the string appear all upper-case with CSS.
@@ -15,7 +15,8 @@ build | |||
.DS_Store | |||
.idea | |||
lighthouse-report.html | |||
.vscode/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nileshgulia1 you might want to re-add this line here for vscode users.
@nileshgulia1 thank you for your work on this! Merged. Would you mind creating another PR with the two small fixes I told you about! |
@tisto okay! I'll do it asap. |
* master: change name of metadata and properties (#893) Move the Tile Edit wrapper one level up to the tiles engine (#895) Cypress create content type (#897) Fix file upload acceptance test (#882) Rework users controlpanel (#891) Dependencies upgrades (router, redux) (#890) User and groups control panel (#608) Add animated gifs for Volto table and toolbar to the docs. Do not run createContent cypress test on Guillotina. Use forEach instead of map in BodyClass.jsx. Remove unused getSpecialList and comment out unused ReferenceWidget import. Fail eslint check on any warnings. Add createContent cypress keyword. Fix typo in login.js acceptance test. Update the acceptance test readme.
#591 @csenger already implemented users control panel i.e ability to add and search for users .
Implementations:
Left overs: