Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event date view #643

Open
wants to merge 23 commits into
base: master
from

Conversation

@nileshgulia1
Copy link
Member

nileshgulia1 commented Feb 22, 2019

nileshgulia1 and others added 3 commits Feb 22, 2019
@sneridagh

This comment has been minimized.

Copy link
Member

sneridagh commented Feb 27, 2019

@nileshgulia1 Can you please do a couple of changes?

We cannot ship it just like this:

screenshot 2019-02-27 at 15 43 34

We need to make it a bit more human. Plone does this, which is not also super fancy, but it is something...

screenshot 2019-02-27 at 15 46 11

We need to use momentjs (we already have it in Volto) to make it look nicer. Please can you take a look at it?

Also, I want you to add a proper EventView for the Event content type (add it to the default config),

export const contentTypesViews = {
So we are not reusing the DocumentView.

@sneridagh

This comment has been minimized.

Copy link
Member

sneridagh commented Feb 27, 2019

@nileshgulia1 I know that there is no mockup for it, but can you please also make it show all the fields that are in the Event content type? Like location, etc... Take a look into the Plone template to know which ones are shown (the ones in the main tab, except the metadata (change etc..) )

@tisto

This comment has been minimized.

Copy link
Member

tisto commented Mar 19, 2019

@nileshgulia1 do you plan to continue to work on this?

@nileshgulia1

This comment has been minimized.

Copy link
Member Author

nileshgulia1 commented Mar 19, 2019

@pnicolli

This comment has been minimized.

Copy link
Contributor

pnicolli commented Jun 23, 2019

Continued work on this during Beethoven Sprint. Up to now, we have a view that shows all fields except recurrence. Also, i18n and some tests are needed.

@pnicolli

This comment has been minimized.

Copy link
Contributor

pnicolli commented Jun 23, 2019

Added more tests. Will have a look at recurrence in the next few hours, at least for the View.

@tisto

This comment has been minimized.

Copy link
Member

tisto commented Sep 20, 2019

@pnicolli what's the status of this PR? Still WIP or something we should review/look into?

@nileshgulia1

This comment has been minimized.

Copy link
Member Author

nileshgulia1 commented Sep 20, 2019

@tisto I started to look into it where @pnicolli left-off.
Just started implementing the recurrence for the View.
Not sure How it should look for the Edit though .

@nileshgulia1 nileshgulia1 force-pushed the event_date-view branch from b3b888f to 7276138 Sep 20, 2019
@pnicolli

This comment has been minimized.

Copy link
Contributor

pnicolli commented Sep 23, 2019

@tisto Unfortunately I don't remember the precise state of the PR but I think it was still waiting for recurrence handling. The conf took most of my energy in the last weeks, we are releasing the final version of the site (the one with the schedule!) in the next few days, I would have some time to work on other things after that, but it's completely ok if @nileshgulia1 goes on from where I left off, I have other PRs I can work on :)

Nilesh, if you find anything that I wrote that you want to discuss, feel free to contact me or comment the code directly here.

nileshgulia1 and others added 2 commits Nov 6, 2019
@pnicolli

This comment has been minimized.

Copy link
Contributor

pnicolli commented Nov 6, 2019

I noticed a bug I introduced in the right column with open-end events and added a quick fix for it.
I see there are improvements for recurrence. Let me know @nileshgulia1 if you need anything and if you will keep working on this, having events working (at least having a default view for them) is becoming more and more important while showing Volto to other people :)

@nileshgulia1

This comment has been minimized.

Copy link
Member Author

nileshgulia1 commented Nov 6, 2019

@pnicolli Hi. Thanks for quick fixes. I'm looking forward to add more conditionals for event occurring biweekly, 'on specific days' and 'repeating events' etc.
Expect this to be finished (at least covering major of the conditionals) by this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.