Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added version overview in controlpanel #778

Merged
merged 5 commits into from Jun 22, 2019

Conversation

@nzambello
Copy link
Contributor

commented Jun 21, 2019

Fixes #671.

I tested it on a production build and it works.
Now there is Volto version number but I put it in a list like versions are displayed on Plone right now, so we can add bulleted prop on List component and include any other useful version numbers as List items, like backend that's in use (Plone/Guillotina).

@nzambello nzambello requested review from sneridagh and tisto Jun 21, 2019
@sneridagh

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

@nzambello Can you take a look at the tests?

Copy link
Member

left a comment

LGTM, after tests are fixed

@nzambello nzambello force-pushed the volto-version-controlpanel branch from 9b3cacc to e210ac5 Jun 21, 2019
nzambello and others added 2 commits Jun 22, 2019
@tisto
tisto approved these changes Jun 22, 2019
@tisto tisto merged commit 544a73f into master Jun 22, 2019
4 checks passed
4 checks passed
Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tisto tisto deleted the volto-version-controlpanel branch Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.