replaced addMessage action with toast component #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@nzambello please do not remove the old actions yet. |
sneridagh
approved these changes
Jun 21, 2019
nzambello
force-pushed
the
toast-component
branch
from
3f002d5 to
3baf01d
Compare
nzambello
force-pushed
the
toast-component
branch
from
3baf01d to
ab25ce5
Compare
* master: (112 commits) Fix container in forms (#840) Fix bulk workflow change in contents view Add proper placeholder to the add link feature in the editor Add proper unique id to all fields, based on the fieldset and field name Fix remove link entity of only a part it only removes that part, not the whole entity Fix reordering in folder contents view and problems with previous windowing settings leaked to current one (#837) Workflow change awareness on toolbar (#836) Export history in start-client.jsx (#835) Fix link popup in case you dismiss it without setting anything (#834) Added link view. Revert "Reduce bundle limit to 600kb." Reduce bundle limit to 600kb. Add bundlesize. Run bundlewatch on Plone suite, we need the bundle. Fix bundlewatch on Travis. Should be sufficient to run bundlewatch on Travis once, not for all test matrix elements. Run bundlewatch after tests when bundle has been created. Upgrade to lodash 4.17.15. Run bundlewatch on Travis. Update yarn.lock. ...
sneridagh
added a commit
that referenced
this pull request
Aug 20, 2019
* master: (31 commits) Add delete file button in file Widget (#821) replaced addMessage action with toast component (#782) Fix container in forms (#840) Fix bulk workflow change in contents view Add proper placeholder to the add link feature in the editor Add proper unique id to all fields, based on the fieldset and field name Fix remove link entity of only a part it only removes that part, not the whole entity Fix reordering in folder contents view and problems with previous windowing settings leaked to current one (#837) Workflow change awareness on toolbar (#836) Export history in start-client.jsx (#835) Fix link popup in case you dismiss it without setting anything (#834) Added link view. Revert "Reduce bundle limit to 600kb." Reduce bundle limit to 600kb. Add bundlesize. Run bundlewatch on Plone suite, we need the bundle. Fix bundlewatch on Travis. Should be sufficient to run bundlewatch on Travis once, not for all test matrix elements. Run bundlewatch after tests when bundle has been created. Upgrade to lodash 4.17.15. ...
sneridagh
added a commit
that referenced
this pull request
Sep 4, 2019
* master: (51 commits) Fix hero tile on view if image is missing (#848) Fix login actions and improve a couple of tests Enable querystring action Fixworkflowcolortoolbar (#847) Querystring widget (#801) Image sidebar (#779) Fix regresion on uploading image to root (#846) Add delete file button in file Widget (#821) replaced addMessage action with toast component (#782) Fix container in forms (#840) Fix bulk workflow change in contents view Add proper placeholder to the add link feature in the editor Add proper unique id to all fields, based on the fieldset and field name Fix remove link entity of only a part it only removes that part, not the whole entity Fix reordering in folder contents view and problems with previous windowing settings leaked to current one (#837) Workflow change awareness on toolbar (#836) Export history in start-client.jsx (#835) Fix link popup in case you dismiss it without setting anything (#834) Added link view. Revert "Reduce bundle limit to 600kb." ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #701.
I introduced the already merged and approved
<Toast />component used withreact-toastifyreplacingaddMessageaction.Should I completely remove add/remove message actions ADD_MESSAGE, REMOVE_MESSAGE and PURGE_MESSAGES?