Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced addMessage action with toast component #782

Merged
merged 5 commits into from Aug 20, 2019

Conversation

@nzambello
Copy link
Contributor

commented Jun 21, 2019

Fixes #701.

I introduced the already merged and approved <Toast /> component used with react-toastify replacing addMessage action.

Should I completely remove add/remove message actions ADD_MESSAGE, REMOVE_MESSAGE and PURGE_MESSAGES?

@nzambello nzambello requested review from sneridagh and tisto Jun 21, 2019
@nzambello nzambello self-assigned this Jun 21, 2019
@sneridagh

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

@nzambello please do not remove the old actions yet.

@nzambello nzambello force-pushed the toast-component branch from 3f002d5 to 3baf01d Jun 21, 2019
@nzambello nzambello force-pushed the toast-component branch from 3baf01d to ab25ce5 Jun 22, 2019
@sneridagh sneridagh added this to the 4.0.0 milestone Aug 19, 2019
sneridagh added 2 commits Aug 20, 2019
* master: (112 commits)
  Fix container in forms (#840)
  Fix bulk workflow change in contents view
  Add proper placeholder to the add link feature in the editor
  Add proper unique id to all fields, based on the fieldset and field name
  Fix remove link entity of only a part it only removes that part, not the whole entity
  Fix reordering in folder contents view and problems with previous windowing settings leaked to current one (#837)
  Workflow change awareness on toolbar (#836)
  Export history in start-client.jsx (#835)
  Fix link popup in case you dismiss it without setting anything (#834)
  Added link view.
  Revert "Reduce bundle limit to 600kb."
  Reduce bundle limit to 600kb.
  Add bundlesize.
  Run bundlewatch on Plone suite, we need the bundle.
  Fix bundlewatch on Travis.
  Should be sufficient to run bundlewatch on Travis once, not for all test matrix elements.
  Run bundlewatch after tests when bundle has been created.
  Upgrade to lodash 4.17.15.
  Run bundlewatch on Travis.
  Update yarn.lock.
  ...
@sneridagh sneridagh merged commit 2ad9dfc into master Aug 20, 2019
5 checks passed
5 checks passed
Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
bundlesize build/public/static/js/bundle.d421a27d.js: 666.76KB < maxSize 680KB (gzip)
Details
bundlewatch Everything is in check (+666.76KB, -0B)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sneridagh sneridagh deleted the toast-component branch Aug 20, 2019
sneridagh added a commit that referenced this pull request Aug 20, 2019
* master: (31 commits)
  Add delete file button in file Widget (#821)
  replaced addMessage action with toast component (#782)
  Fix container in forms (#840)
  Fix bulk workflow change in contents view
  Add proper placeholder to the add link feature in the editor
  Add proper unique id to all fields, based on the fieldset and field name
  Fix remove link entity of only a part it only removes that part, not the whole entity
  Fix reordering in folder contents view and problems with previous windowing settings leaked to current one (#837)
  Workflow change awareness on toolbar (#836)
  Export history in start-client.jsx (#835)
  Fix link popup in case you dismiss it without setting anything (#834)
  Added link view.
  Revert "Reduce bundle limit to 600kb."
  Reduce bundle limit to 600kb.
  Add bundlesize.
  Run bundlewatch on Plone suite, we need the bundle.
  Fix bundlewatch on Travis.
  Should be sufficient to run bundlewatch on Travis once, not for all test matrix elements.
  Run bundlewatch after tests when bundle has been created.
  Upgrade to lodash 4.17.15.
  ...
sneridagh added a commit that referenced this pull request Sep 4, 2019
* master: (51 commits)
  Fix hero tile on view if image is missing (#848)
  Fix login actions and improve a couple of tests
  Enable querystring action
  Fixworkflowcolortoolbar (#847)
  Querystring widget (#801)
  Image sidebar (#779)
  Fix regresion on uploading image to root (#846)
  Add delete file button in file Widget (#821)
  replaced addMessage action with toast component (#782)
  Fix container in forms (#840)
  Fix bulk workflow change in contents view
  Add proper placeholder to the add link feature in the editor
  Add proper unique id to all fields, based on the fieldset and field name
  Fix remove link entity of only a part it only removes that part, not the whole entity
  Fix reordering in folder contents view and problems with previous windowing settings leaked to current one (#837)
  Workflow change awareness on toolbar (#836)
  Export history in start-client.jsx (#835)
  Fix link popup in case you dismiss it without setting anything (#834)
  Added link view.
  Revert "Reduce bundle limit to 600kb."
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.