Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes shift+return create a new line in a text tile #785

Open
wants to merge 24 commits into
base: master
from

Conversation

@rodfersou
Copy link
Member

commented Jun 22, 2019

  • Add shift+return for Text tile
  • Added cypress tests for every tile
    image

Those should be fixed on other PR:

  • The hero tile needs to implement react dropzone to be able to finish the test. #804
  • Table tile not working (at least for tests). #805
  • Tiles Image, Video and Maps don't work in Guilhotina. #806
  • Improve Text tile test. #807
@rodfersou rodfersou requested review from robgietema and sneridagh Jun 22, 2019
ThomasKindermann and others added 2 commits Jun 22, 2019
@tisto

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

@rodfersou the new cypress test fails.

rodfersou and others added 5 commits Jun 22, 2019
@robgietema

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

The description is saved as a string right? and rendered HTML, so the newline will not be visible. What is the reason we want this functionality?

@tisto

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

@robgietema @rodfersou shift-return should work in regular text tiles to being able to create quotes where you control the carriage return. No idea why that ended up in the description field.

tisto and others added 7 commits Jun 23, 2019
@rodfersou

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

@tisto @robgietema should be green after last change.

Please take a look at this comment where I sum up the state of the PR and tests #785 (comment)

@rodfersou

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

finally green!

@@ -0,0 +1,286 @@
describe('Default Tiles functionality', () => {

This comment has been minimized.

Copy link
@tisto

tisto Jun 25, 2019

Member

There is no "default" tile. This is the "Text tile".

This comment has been minimized.

Copy link
@rodfersou

rodfersou Jun 25, 2019

Author Member

maybe we can review the structure of the tests later, for something that makes more sense.
right now I just put all tests in the same describe

}
});

it('Table Tile', () => {

This comment has been minimized.

Copy link
@tisto

tisto Jun 25, 2019

Member

There is no table tile in master yet. Therefore we should remove this test altogether.

This comment has been minimized.

Copy link
@robgietema

robgietema Jun 25, 2019

Member

Yes there is.

This comment has been minimized.

Copy link
@tisto

tisto Jun 25, 2019

Member

@robgietema w00t. That's fantastic! Man, do you ever eat or sleep like other humans? ;)

@tisto tisto changed the title Makes shift+return create new line in Description field Makes shift+return create a new line in a text tile Jun 25, 2019
<Button
icon
basic
className="show-hidden-tiles"

This comment has been minimized.

Copy link
@tisto

tisto Jun 25, 2019

Member

@rodfersou is "show-hidden-tiles" an existing class in our css?

This comment has been minimized.

Copy link
@rodfersou

rodfersou Jun 25, 2019

Author Member

No, I just use this class to fire the button in the test

@@ -4,6 +4,7 @@

### Added

- Makes shift+return create new line in Description field @rodfersou

This comment has been minimized.

Copy link
@tisto

tisto Jul 21, 2019

Member

@rodfersou pls replace "Description field" with "Text tile".

This comment has been minimized.

Copy link
@rodfersou

rodfersou Jul 28, 2019

Author Member

done

rodfersou added 2 commits Jul 28, 2019
@sneridagh sneridagh added this to the 4.0.0 milestone Aug 19, 2019
@tisto tisto added this to In progress in Volto 4 Sep 20, 2019
tisto and others added 6 commits Sep 20, 2019
…ng to do with this PR.
@tisto

This comment has been minimized.

Copy link
Member

commented Sep 22, 2019

@rodfersou please try not to mix two different issues (shift+return, tiles tests) into one PR in the future. This makes things harder to review and merge.

@sneridagh

This comment has been minimized.

Copy link
Member

commented Sep 22, 2019

@tisto FYI I've fixed a lot of issues and created a special redraftJS toHTML function to deal with this, I don't think that it's backported yet.

@tisto

This comment has been minimized.

Copy link
Member

commented Sep 22, 2019

@rodfersou could you image to look into this again after Victor's refactoring? Maybe it is better to create a new branch for this.

@tisto

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

@rodfersou it turns out we had to put quite some effort into make this work in our recent project. We have the code in one of our projects and we need to copy it over to Volto core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Volto 4
  
In progress
6 participants
You can’t perform that action at this time.