Makes shift+return create a new line in a text tile #785
Conversation
|
@rodfersou the new cypress test fails. |
|
The description is saved as a string right? and rendered HTML, so the newline will not be visible. What is the reason we want this functionality? |
|
@robgietema @rodfersou shift-return should work in regular text tiles to being able to create quotes where you control the carriage return. No idea why that ended up in the description field. |
|
@tisto @robgietema should be green after last change. Please take a look at this comment where I sum up the state of the PR and tests #785 (comment) |
|
finally green! |
cypress/integration/tiles.js
Outdated
| @@ -0,0 +1,286 @@ | |||
| describe('Default Tiles functionality', () => { | |||
There was a problem hiding this comment.
There is no "default" tile. This is the "Text tile".
There was a problem hiding this comment.
maybe we can review the structure of the tests later, for something that makes more sense.
right now I just put all tests in the same describe
| } | ||
| }); | ||
|
|
||
| it('Table Tile', () => { |
There was a problem hiding this comment.
There is no table tile in master yet. Therefore we should remove this test altogether.
There was a problem hiding this comment.
@robgietema w00t. That's fantastic! Man, do you ever eat or sleep like other humans? ;)
tisto
changed the title
| <Button | ||
| icon | ||
| basic | ||
| className="show-hidden-tiles" |
There was a problem hiding this comment.
@rodfersou is "show-hidden-tiles" an existing class in our css?
There was a problem hiding this comment.
No, I just use this class to fire the button in the test
CHANGELOG.md
Outdated
|
|
||
| ### Added | ||
|
|
||
| - Makes shift+return create new line in Description field @rodfersou |
There was a problem hiding this comment.
@rodfersou pls replace "Description field" with "Text tile".
…ng to do with this PR.
|
@rodfersou please try not to mix two different issues (shift+return, tiles tests) into one PR in the future. This makes things harder to review and merge. |
|
@tisto FYI I've fixed a lot of issues and created a special redraftJS |
|
@rodfersou could you image to look into this again after Victor's refactoring? Maybe it is better to create a new branch for this. |
|
@rodfersou it turns out we had to put quite some effort into make this work in our recent project. We have the code in one of our projects and we need to copy it over to Volto core. |
|
Superseeded by #1044. @rodfersou I tried the ctrl+shift test but it failed :( |
|
Fixed in master. Closing. |
Those should be fixed on other PR: