Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SidebarPortal component #798

Merged
1 commit merged into from Jun 23, 2019

Conversation

@pnicolli
Copy link
Contributor

commented Jun 22, 2019

This allows for easier sidebar management, since it hides some internal details (like __CLIENT__ and the id of the sidebar html element), and helps tile developers to only show the sidebar when the tile is selected.

Upgraded Enzyme because shallow rendering allows for simple snapshots of the portal component. react-test-renderer regular renderer does not allow rendering Portals.

@sneridagh
Copy link
Member

left a comment

LGTM

@pnicolli

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2019

Apparently, after merging this something happened with github and @sneridagh and I can't see options to remove branch and/or close this. @robgietema Do you see those?

sneridagh added a commit that referenced this pull request Jun 23, 2019
Merge branch 'master' into viklatesttoolbar
* master:
  Fixed tiles outline in pastanaga editor
  Update changelog.
  Finish table tile.
  Added portal.
  Add table tile.
  Added SidebarPortal component (#798)
  Internal API path
  Adding internal API Path

@robgietema robgietema closed this Jun 23, 2019

@robgietema robgietema deleted the sidebar_portal branch Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.