Add infrastructure to build as an ITK module and facilitate CI testing #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address:
/home/matt/src/kretz/include/itkToroidalToCartesianTransform.h:120:25:
warning: 'TransformPoint' overrides a member function but is not marked
'override' [-Winconsistent-missing-override]
OutputPointType TransformPoint(const InputPointType &point )
const;
To address:
/home/matt/src/kretz/test/itkToroidalTransformTest.cxx:163:43: warning: suggest braces around initialization of subobject [-Wmissing-braces]
ImageType::SizeType cartesian_size = {410, 418, 318};
^~~~~~~~~~~~~
{ }
/home/matt/src/kretz/test/itkToroidalTransformTest.cxx:164:42: warning: suggest braces around initialization of subobject [-Wmissing-braces]
ImageType::SizeType size_toroidal = {580, 180, 142};
^~~~~~~~~~~~~
{ }
This enables CI testing as use as a library. This contains the output of the ITK module template: https://github.com/InsightSoftwareConsortium/ITKModuleTemplate Running: python -m pip install cookiecutter python -m cookiecutter gh:InsightSoftwareConsortium/ITKModuleTemplate By conventions for ITK IO modules, the name is "IOKretz". The CMake project name and libraries correspond to this name. The example applications are moved in the "examples" directory per ITK module convention. Fix style issues identified by IOKretzKWStyleTest. Update license to standard Apache 2.0 license with copyright assigned to the Insight Software Consortium. Add CircleCI configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the license to the standard Apache 2.0 license used for ITK module. If this license is not desired, the license header should be removed from the source files and a license header ignore should be added to
KWStyleOverwrite.txt.CircleCI testing configuration is added (untested). You will need to enable CircleCI on the repository and verify that it works as expected.