From 6f8c02699043d2a41b777c42f77f1a511fd3069f Mon Sep 17 00:00:00 2001 From: Liam Connors Date: Wed, 5 Mar 2025 09:25:20 -0500 Subject: [PATCH 1/3] Update ChromeNotFoundError text --- src/py/kaleido/kaleido.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/py/kaleido/kaleido.py b/src/py/kaleido/kaleido.py index e2fc01f7..16c41afe 100644 --- a/src/py/kaleido/kaleido.py +++ b/src/py/kaleido/kaleido.py @@ -120,11 +120,9 @@ def __init__(self, *args, **kwargs): # noqa: D417 no args/kwargs in description super().__init__(*args, **kwargs) except ChromeNotFoundError: raise ChromeNotFoundError( - "Versions 1.0.0 and higher of Kaleido do not include chrome by" - "default. Earlier versions, which can be pinned, did but the strategy " - "is no longer tenable. Kaleido's supplies a kaleido_get_chrome CLI " - "command as well as a `get_chrome()` and `get_chrome_sync()` " - "functions in kaleido.", + "Kaleido requires Chrome to be installed. To install Chrome, " + "use the CLI command `kaleido_get_chrome`, or from Python " + "use either `kaleido.get_chrome` or `kaleido.get_chrome_sync`.", ) from ChromeNotFoundError if page and isinstance(page, str) and Path(page).is_file(): From 67520de1c8fed07b4921f84ca66fed09e053fdcb Mon Sep 17 00:00:00 2001 From: Liam Connors Date: Tue, 11 Mar 2025 17:08:47 -0400 Subject: [PATCH 2/3] Update kaleido.py --- src/py/kaleido/kaleido.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/py/kaleido/kaleido.py b/src/py/kaleido/kaleido.py index 16c41afe..859f9153 100644 --- a/src/py/kaleido/kaleido.py +++ b/src/py/kaleido/kaleido.py @@ -122,7 +122,7 @@ def __init__(self, *args, **kwargs): # noqa: D417 no args/kwargs in description raise ChromeNotFoundError( "Kaleido requires Chrome to be installed. To install Chrome, " "use the CLI command `kaleido_get_chrome`, or from Python " - "use either `kaleido.get_chrome` or `kaleido.get_chrome_sync`.", + "use either `kaleido.get_chrome()` or `kaleido.get_chrome_sync()`.", ) from ChromeNotFoundError if page and isinstance(page, str) and Path(page).is_file(): From 63e1a7d4bbd37107f54a742da3474544fb057f81 Mon Sep 17 00:00:00 2001 From: Liam Connors Date: Mon, 24 Mar 2025 13:28:45 -0400 Subject: [PATCH 3/3] Make small updates to ChromeNotFoundError --- src/py/kaleido/kaleido.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/py/kaleido/kaleido.py b/src/py/kaleido/kaleido.py index 859f9153..b1404b45 100644 --- a/src/py/kaleido/kaleido.py +++ b/src/py/kaleido/kaleido.py @@ -120,9 +120,10 @@ def __init__(self, *args, **kwargs): # noqa: D417 no args/kwargs in description super().__init__(*args, **kwargs) except ChromeNotFoundError: raise ChromeNotFoundError( - "Kaleido requires Chrome to be installed. To install Chrome, " - "use the CLI command `kaleido_get_chrome`, or from Python " - "use either `kaleido.get_chrome()` or `kaleido.get_chrome_sync()`.", + "Kaleido v1 and later requires Chrome to be installed. " + "To install Chrome, use the CLI command `kaleido_get_chrome`, " + "or from Python, use either `kaleido.get_chrome()` " + "or `kaleido.get_chrome_sync()`.", ) from ChromeNotFoundError if page and isinstance(page, str) and Path(page).is_file():