From 4e6e33bd0c8ca43d63a81b201ba4bd637a29eec6 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 24 Apr 2026 11:30:41 +0000 Subject: [PATCH 1/3] Initial plan From bf447dc3ebe495a2fe0f194a4e43144fedf235d7 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 24 Apr 2026 11:44:36 +0000 Subject: [PATCH 2/3] fix: avoid forwarding getRows request/response props to AG Grid Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/74aea7f9-fb2b-465b-9427-72b17314c792 Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com> --- CHANGELOG.md | 1 + src/lib/utils/propCategories.js | 6 +++--- tests/test_infinite_scroll.py | 10 ++++++++-- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a4bb9f02..1d1b9af2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source D ### Fixed - [#454](https://github.com/plotly/dash-ag-grid/pull/454) fixes issue where a rowCount of 0 would cause the grid not to display new data +- Fixed `getRowsRequest` / `getRowsResponse` warnings by excluding these Dash callback props from AG Grid options. ## [35.2.0] - 2026-04-03 ### Added diff --git a/src/lib/utils/propCategories.js b/src/lib/utils/propCategories.js index 7528c2a2..b4de10a8 100644 --- a/src/lib/utils/propCategories.js +++ b/src/lib/utils/propCategories.js @@ -351,8 +351,8 @@ export const PROPS_NOT_FOR_AG_GRID = [ 'cellValueChanged', 'cellClicked', 'cellDoubleClicked', - 'getRowRequest', - 'getRowResponse', + 'getRowsRequest', + 'getRowsResponse', 'getDetailRequest', 'getDetailResponse', 'dangerously_allow_code', @@ -383,7 +383,7 @@ export const OMIT_PROP_RENDER = [ 'virtualRowData', 'columnState', 'filterModel', - 'getRowRequest', + 'getRowsRequest', 'getDetailRequest', 'cellValueChanged', 'cellClicked', diff --git a/tests/test_infinite_scroll.py b/tests/test_infinite_scroll.py index 6294c104..bfed0fea 100644 --- a/tests/test_infinite_scroll.py +++ b/tests/test_infinite_scroll.py @@ -247,7 +247,13 @@ def scroll(n): for x in range(8): dash_duo.find_element("#scroll").click() time.sleep(3) # pausing to emulate separation because user inputs - assert list(filter(lambda i: i.get("level") != "WARNING", dash_duo.get_logs())) == [] + logs = dash_duo.get_logs() + assert list(filter(lambda i: i.get("level") != "WARNING", logs)) == [] + assert not any( + "invalid gridOptions property 'getRowsRequest'" in log.get("message", "") + or "invalid gridOptions property 'getRowsResponse'" in log.get("message", "") + for log in logs + ) def test_is003_infinite_scroll_clear(dash_duo): app = Dash(__name__) @@ -330,4 +336,4 @@ def update_rfq_grid_rows( ) dash_duo.find_element("#reset").click() grid_dom.wait_for_cell_text(0, 0, "0") - assert x == len(test_data) # make sure the callback was called the expected number of times \ No newline at end of file + assert x == len(test_data) # make sure the callback was called the expected number of times From 2249a05b5c4c21aa504add70da7a02f67d308325 Mon Sep 17 00:00:00 2001 From: BSd3v <82055130+BSd3v@users.noreply.github.com> Date: Fri, 24 Apr 2026 14:56:17 -0400 Subject: [PATCH 3/3] Update CHANGELOG.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fd3f30ee..a6983a77 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,7 @@ Links "DE#nnn" prior to version 2.0 point to the Dash Enterprise closed-source D ### Fixed - [#454](https://github.com/plotly/dash-ag-grid/pull/454) fixes issue where a rowCount of 0 would cause the grid not to display new data -- [#459](https://github.com/plotly/dash-ag-grid/pull/459) `getRowsRequest` / `getRowsResponse` warnings by excluding these Dash callback props from AG Grid options. +- [#459](https://github.com/plotly/dash-ag-grid/pull/459) removes `getRowsRequest` / `getRowsResponse` warnings by excluding these Dash callback props from AG Grid options. - [#460](https://github.com/plotly/dash-ag-grid/pull/460) fix grid rendering when `getRowId` is explicitly set to `None` ## [35.2.0] - 2026-04-03