Change wording to use 'index' instead of 'row', in accordance with Pa… #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkcor
reviewed
Jan 24, 2019
tests/dash/app_clustergram.py
Outdated
| title='If a dataset was uploaded, enter the header of' + | ||
| 'the column that contains the title of each row.', | ||
| 'the column that contains the indices.', |
There was a problem hiding this comment.
Oh, okay, now I understand the meaning! I would therefore suggest the more conventional phrasing "enter the name of the column to use as index."
Co-Authored-By: shammamah <shammamah.hossain@gmail.com>
mkcor
reviewed
Jan 25, 2019
mkcor
reviewed
Jan 25, 2019
Co-Authored-By: shammamah <shammamah.hossain@gmail.com>
Co-Authored-By: shammamah <shammamah.hossain@gmail.com>
mkcor
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ndas convention.
Closes #125.
About
Description of changes
Changed wording for title prop of the clustergram app control that specifies the column to use for reading row labels.
Before merging