Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: pass className to RadioItems #57

Closed
jamestwebber opened this issue Aug 12, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@jamestwebber
Copy link

commented Aug 12, 2017

I've got a couple RadioItems controls for a plot, arranged like so:

screen shot 2017-08-12 at 11 52 17 am

I originally tried to just pass className="six columns" to the RadioItems component but that's not an accepted keyword (for some reason—I thought it would be inherited). So as a workaround I wrapped them in extra divs with the six columns class. Given that a RadioItems component renders as a div anyway, it would be a wee bit cleaner to be able to pass the class in directly to that div and save a layer of layout boilerplate.

I don't know if the same issue applies to any other components. It seems to work in some cases (e.g. Dropdown takes className as a keyword) but in general any component that ends up wrapped in its own div could benefit from this.

Thanks again for all your hard work on this package!

@chriddyp

This comment has been minimized.

Copy link
Member

commented Aug 22, 2017

Great suggestion @jamestwebber ! Fixed in #60, available in v0.12.4. Upgrade with

pip install dash-core-components==0.12.4

@chriddyp chriddyp closed this Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.