Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input with type number should return number after value change #100

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
2 participants
@Madhu94
Copy link
Contributor

commented Oct 19, 2017

Attempting to close plotly/dash#124. @chriddyp, please let me know if I should do something else here.

@@ -21,15 +21,22 @@ export default class Input extends Component {
render() {
const {
fireEvent,
setProps
setProps,
inputType

This comment has been minimized.

@chriddyp

This comment has been minimized.

Copy link
Member

commented Nov 2, 2017

This looks great @Madhu94, thank you! Just one small comment about the prop name.

@Madhu94 Madhu94 force-pushed the Madhu94:cast-types-input-component branch from bf740f2 to 26aa9d0 Nov 3, 2017

@Madhu94

This comment has been minimized.

Copy link
Contributor Author

commented Nov 3, 2017

@chriddyp Is this good to go now ?

@chriddyp

This comment has been minimized.

Copy link
Member

commented Nov 3, 2017

Looks great @Madhu94 , thank you!

@chriddyp chriddyp merged commit 40a0d87 into plotly:master Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.