Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some warnings #106

Merged
merged 6 commits into from Nov 2, 2017

Conversation

Projects
None yet
2 participants
@Akronix
Copy link
Contributor

commented Oct 31, 2017

Looking the browser console I got these warnings:

Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of `RadioItems`. See https://fb.me/react-warning-keys for more information.
    in label (created by RadioItems)
    in RadioItems
Warning: Failed prop type: Invalid prop `options` of type `array` supplied to `Checklist`, expected `object`.
    in Checklist (created by Controller)
    in Controller

This fixes them.

@Akronix Akronix changed the title Fixed propType for options and added key in map for RadioItems component Fixed some warnings Oct 31, 2017

@Akronix

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2017

I've located and resolved several more warnings I've found when running the demo.

@chriddyp

This comment has been minimized.

Copy link
Member

commented Nov 2, 2017

This is great, thank you @Akronix !

@chriddyp chriddyp merged commit 5da557a into plotly:master Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.