Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current date's initial visible month #201

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@xblad
Copy link

commented May 16, 2018

Added current date as the last resort for the initialVisibleMonth property of the component in DatePickerRange.react.js and in DatePickerSingle.react.js (issue #115)

@chriddyp

This comment has been minimized.

Copy link
Member

commented May 22, 2018

Thanks! This looks good to me. A few other things would be helpful:

  • Would you mind adding a test? We can just render the component and then take a screenshot of the new behaviour.
  • Would you mind updating the CHANGELOG.md and the version numbers in version.py and package.json?

@xblad xblad force-pushed the xblad:patch-1 branch from c415a1b to 70ac705 May 22, 2018

Fix for datepicker initial month
Added current date as the last resort for the initialVisibleMonth property of the component in DatePickerRange.react.js and in DatePickerSingle.react.js (issue #115)

@xblad xblad force-pushed the xblad:patch-1 branch from 70ac705 to e93b096 May 22, 2018

@xblad

This comment has been minimized.

Copy link
Author

commented May 22, 2018

@chriddyp, I have added the tests and updated version number (v0.22.3 + tag) and GHANGELOG.md.
Nevertheless, it is my first contribution on Github, so quick revision of the changes is highly appreciated 😃
Btw, I see, that percy/dash-core-components test was failed, but I don't have an access to the resource, so I'm not able to check why...

@valentijnnieman

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2018

@chriddyp This seems solid - can we update & merge this? 💃

@mikesmith1611

This comment has been minimized.

Copy link

commented Jul 17, 2018

It looks like change has been implemented:
https://dash.plot.ly/dash-core-components/datepickersingle
can confirm it works

@valentijnnieman

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

@xblad Hi! Sorry that it took so long, this should've been merged already! There are now some merge conflicts though - would you be able to solve them? If so, I can help you with rebuilding the package. Alternatively, I could fix the merge conflicts myself, but I would have to create a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.