Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Improved Link component #215
This improves the Link component somewhat, so that users can right-click on it etc. It also scrolls back to top when clicking a link. The fix is basically adding a href attribute to the tag rendered, so that the browser treats it as a native link. Should fix #99
This is very interesting. I wonder how we can test this with our integration tests.
Let's publish a prerelease version and test this on the dash-docs page. To create a prerelease:
4 - Publish:
5 - Create a PR in dash-docs by editing the
6 - Comment on this thread when the prerelease version has been published, so that community members can take it for a spin as well
@chriddyp I've written a test that should test if the page scrolls back up (should verify snapshot on Percy), if it updates the Location, and tests if the tag that is rendered by Link contains an href attribute with the correct href. My thinking is that if this is the case, then the tag should/must be right-clickable in browsers.
edit: So Percy takes a snapshot of the entire page of course, making my test for checking if scrolled to the top a bit useless. Any suggestions on how to test this properly?
edit-2: I've updated the version for prerelease, but unfortunately can't seem to publish.