Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve unminified bundle support #293

Merged
merged 6 commits into from Sep 20, 2018

Conversation

Projects
None yet
3 participants
@T4rk1n
Copy link
Contributor

commented Sep 6, 2018

Add build:js-dev command and support in _js_dist.

plotly/dash#369

@rmarren1

This comment has been minimized.

Copy link
Contributor

commented Sep 7, 2018

💃 I had that percy issue before, I think it goes away when you rebase. Can you do that before merging to make sure?

@T4rk1n

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2018

Renamed the bundles plotly/dash#384

@T4rk1n T4rk1n force-pushed the serve-unminified branch from 8dff0bf to 43924f0 Sep 13, 2018

@T4rk1n

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2018

@valentijnnieman Can you look at the percy diff ? I rebased on master an hour ago and it looks like there is a regression in the tabs.

@valentijnnieman

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2018

@T4rk1n Looks like the Graph is rendered differently with the new version of plotly.js, looks better to me :-)

@valentijnnieman

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2018

@T4rk1n Percy is being a little bit difficult lately it seems... Feels like the snapshots are changing slightly every time it runs. Maybe if we replace the tests with the Selenium WaitAPI instead of the time.sleep() it will be more stable?

@T4rk1n

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2018

@valentijnnieman Yea, I think you can go ahead with the Selenium WaitAPI if you have the time.

T4rk1n added some commits Sep 20, 2018

@T4rk1n T4rk1n merged commit 2805c8f into master Sep 20, 2018

4 checks passed

ci/circleci: python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
percy/dash-core-components Visual review approved by Philippe Duval
Details

@T4rk1n T4rk1n deleted the serve-unminified branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.