Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm start to run Demo app #359

Merged
merged 2 commits into from Nov 1, 2018

Conversation

Projects
None yet
2 participants
@valentijnnieman
Copy link
Contributor

commented Nov 1, 2018

@T4rk1n I've changed the webpack config to resemble plotly/dash-component-boilerplate#28, can you please review? There's some more noise again in the build, can you confirm that these changes are coming from builds with py3 (like you mentioned here) or is there more going on? Is there a way of preventing this from happening?

@valentijnnieman valentijnnieman requested a review from T4rk1n Nov 1, 2018

@T4rk1n

T4rk1n approved these changes Nov 1, 2018

Copy link
Contributor

left a comment

💃, yea it's from the build, let's get this in so they gone !!

@valentijnnieman

This comment has been minimized.

Copy link
Contributor Author

commented Nov 1, 2018

Closes #346

@valentijnnieman valentijnnieman merged commit 4d6ac98 into master Nov 1, 2018

4 checks passed

ci/circleci: python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
percy/dash-core-components Visual review automatically approved, no visual changes found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.