Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `.map` files to manifest. #413

Merged
merged 2 commits into from Dec 11, 2018

Conversation

Projects
None yet
3 participants
@T4rk1n
Copy link
Contributor

commented Dec 10, 2018

The map files were not included in the python build.

cc @Marc-Andre-Rivet @valentijnnieman

@T4rk1n T4rk1n requested a review from valentijnnieman Dec 10, 2018

@Marc-Andre-Rivet
Copy link
Contributor

left a comment

💃 Checked and I didn't forget to add those on the table and on the renderer :)

include dash_core_components/dash_core_components.dev.js
include dash_core_components/dash_core_components.dev.js.map

This comment has been minimized.

Copy link
@Marc-Andre-Rivet

@T4rk1n T4rk1n merged commit f18a20f into master Dec 11, 2018

4 checks passed

ci/circleci: python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
percy/dash-core-components Visual review automatically approved, no visual changes found.
Details

@T4rk1n T4rk1n deleted the fix-map branch Dec 11, 2018

@Alexfinkelshtein

This comment has been minimized.

Copy link

commented Dec 18, 2018

I'm getting the following:
127.0.0.1 - - [18/Dec/2018 17:51:46] "GET /_dash-component-suites/dash_core_components/dash_core_components.dev.js.map?v=0.40.4&m=1545148181 HTTP/1.1" 500 -
Traceback (most recent call last):
since this version can you explain what am I missing?

@Marc-Andre-Rivet

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2018

@Alexfinkelshtein Please open an issue or use the community forum when encountering issues in the future. We do not usually watch out for comments on closed PRs. The likely culprit is that your dash package needs to be updated to >=0.32 for the map files to be exposed by the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.