Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plotly.js #423

Merged
merged 3 commits into from Dec 27, 2018

Conversation

Projects
None yet
3 participants
@T4rk1n
Copy link
Contributor

commented Dec 24, 2018

  • Updated plotly.js to 1.43.1

Closes #421

@T4rk1n T4rk1n force-pushed the update-plotlyjs branch 2 times, most recently from db130b2 to 833d4ad Dec 24, 2018

@T4rk1n T4rk1n requested a review from alexcjohnson Dec 24, 2018

@cldougl
Copy link
Member

left a comment

💃 after changelog edit

@@ -2,6 +2,96 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [0.42.0] - 2018-12-24
### Updated
- Updated plotly.js to 1.43.0 [#423](https://github.com/plotly/dash-core-components/pull/423)

This comment has been minimized.

Copy link
@cldougl

cldougl Dec 27, 2018

Member

this could be 1.43.1 since that's the version added

### As part of [plotly.js 1.43.1](https://github.com/plotly/plotly.js/releases/tag/v1.43.1)

### Fixed
- Fix z-axis auto-type for cartesian + gl3d graphs (bug introduced in 1.43.0) [#3360]

This comment has been minimized.

Copy link
@alexcjohnson

alexcjohnson Dec 27, 2018

Contributor

This isn't new in this PR, but... importing the whole plotly.js changelog en masse means that all of these links are broken, and ideally would need to be prefixed with plotly/plotly.js

This comment has been minimized.

Copy link
@T4rk1n

T4rk1n Dec 27, 2018

Author Contributor

Opened #425 for that.

@T4rk1n T4rk1n force-pushed the update-plotlyjs branch from 833d4ad to 2cbbe06 Dec 27, 2018

@T4rk1n T4rk1n merged commit aa2ff08 into master Dec 27, 2018

4 checks passed

ci/circleci: python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
percy/dash-core-components No visual changes since last approval
Details

@T4rk1n T4rk1n deleted the update-plotlyjs branch Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.