Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump plotly.js to version 1.44.3 #458

Merged
merged 3 commits into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@cldougl
Copy link
Member

commented Feb 8, 2019

Update plotly.js version (for plotly/dash-design-kit#227)

changelog coming momentarily

@cldougl cldougl requested a review from Marc-Andre-Rivet Feb 8, 2019

@Marc-Andre-Rivet

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2019

Needs to be linked back to the plotly.js entries (https://github.com/plotly/plotly.js/releases) in the changelog. In this case, something like:

### Updated
[#458](https://github.com/plotly/dash-core-components/pull/458)
- Upgraded plotly.js to 1.44.3
  - Patch releases [1.44.2](https://github.com/plotly/plotly.js/releases/tag/v1.44.2) and [1.44.3](https://github.com/plotly/plotly.js/releases/tag/v1.44.3) containing numerous bug fixes
- Fixed axis `automargin` push offset
- Fix handling of alpha channel in rgba coloring in `scatter3d` traces
- Fixed subplots with multiple `carpet` traces
- Fixed MathJax placement in ternary `aaxis` titles

This comment has been minimized.

Copy link
@Marc-Andre-Rivet

Marc-Andre-Rivet Feb 8, 2019

Contributor

Alright. Cool. Now for 1.44.2 :)

This comment has been minimized.

Copy link
@alexcjohnson

alexcjohnson Feb 8, 2019

Contributor

@cldougl apologies, this is a recent change but I don't want to include all the details of the plotly.js releases in the dcc changelog - just the highlights for new features, and no extra info for bugfixes. Otherwise the dcc changelog gets swamped by plotly.js features. You can just use exactly the text @Marc-Andre-Rivet wrote above.

This comment has been minimized.

Copy link
@cldougl

cldougl Feb 8, 2019

Author Member

no problem! let me update that

@alexcjohnson
Copy link
Contributor

left a comment

Thanks! 💃

@cldougl cldougl merged commit 2f592e4 into master Feb 8, 2019

4 checks passed

ci/circleci: python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
percy/dash-core-components Visual review automatically approved, no visual changes found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.