Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:bug: fix loading_state props for input #498

Merged
merged 2 commits into from Mar 26, 2019

Conversation

Projects
None yet
2 participants
@byronz
Copy link
Contributor

commented Mar 25, 2019

the loading_state should not be specified as props, as it already specified by data-* at top.

@Marc-Andre-Rivet
Copy link
Contributor

left a comment

💃(build pending) I'm fine with this not having a changelog entry as the bug should only be expressed in React 16

@Marc-Andre-Rivet

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

@byronz py37 failed on test_graphs_with_different_figures this is as in plotly/dash-core#54 -- just rerun the tests...

@byronz byronz merged commit 6abe86c into master Mar 26, 2019

4 checks passed

ci/circleci: python-2.7 Your tests passed on CircleCI!
Details
ci/circleci: python-3.6 Your tests passed on CircleCI!
Details
ci/circleci: python-3.7 Your tests passed on CircleCI!
Details
percy/dash-core-components Visual review automatically approved, no visual changes found.
Details

@byronz byronz deleted the fix-input-loading-state branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.