Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add `className` and `style` to more components + style updates + percy integration #60

Merged
merged 12 commits into from Aug 22, 2017

Conversation

Projects
None yet
2 participants
@chriddyp
Copy link
Member

commented Aug 21, 2017

@alishobeiri - could you review this? best done commit-by-commit probably

chriddyp added some commits Aug 21, 2017

reorder props so that `options` and `value` are among the first
these are the most common options, so they should appear first
clean up passing props through to component
this wasn’t causing any bugs but it was passing unnecessary props into
the child components
@chriddyp

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2017

Fixes #57

@chriddyp chriddyp changed the title add `className` and `style` to more components + style updates add `className` and `style` to more components + style updates + percy integration Aug 22, 2017

chriddyp added some commits Aug 22, 2017

@chriddyp chriddyp force-pushed the py3tests branch from 3757e3d to 0bca03e Aug 22, 2017

@@ -34,7 +34,7 @@ export default class Slider extends Component {
}
}}
value={value}
{...omit('value', this.props)}
{...omit(['fireEvent', 'setProps', 'value'], this.props)}

This comment has been minimized.

Copy link
@alishobeiri

alishobeiri Aug 22, 2017

Contributor

Maybe could add updatemode here as well

This comment has been minimized.

Copy link
@chriddyp

chriddyp Aug 22, 2017

Author Member

nice catch, thanks!



/**
* The style of the <input> radio element

This comment has been minimized.

Copy link
@alishobeiri

alishobeiri Aug 22, 2017

Contributor

Should read checkbox instead of radio

@chriddyp chriddyp closed this Aug 22, 2017

@chriddyp chriddyp reopened this Aug 22, 2017


/**
* The value of the checkbox. This value
* corresponds to the items specified in the

This comment has been minimized.

Copy link
@alishobeiri

alishobeiri Aug 22, 2017

Contributor

Should read radioitem instead of checkbox

value: PropTypes.string,

/**
* If true, this checkbox is disabled and can't be clicked on.

This comment has been minimized.

Copy link
@alishobeiri

alishobeiri Aug 22, 2017

Contributor

radioitem instead of checkbox

@alishobeiri

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2017

Otherwise I think looks good

@alishobeiri

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2017

💃 :D

chriddyp added some commits Aug 22, 2017

@chriddyp chriddyp merged commit a4d0226 into master Aug 22, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@chriddyp chriddyp deleted the py3tests branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.