make sure tooltips aren't visible when parent slider isn't #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamiba
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
Marc-Andre-Rivet
suggested changes
Oct 27, 2020
There was a problem hiding this comment.
@jdamiba This PR will need:
- a changelog.md entry for the bug being fixed
- a test that shows this works -- I think in this case a simple visual test saved in Percy will do the trick. Can be based on the issue's example code. No need for interactivity or anything like that.
- I suggest you add a comment in the code to the effect that if/when we'll update rc-slider / rc-tooltip we will need to revisit this code as the getTooltipContainer function will need to be a prop instead of a nested property
CHANGELOG.md
Outdated
| @@ -7,6 +7,8 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| - [#871](https://github.com/plotly/dash-core-components/pull/871) Add Julia syntax highlighting support for dcc.Markdown | |||
|
|
|||
| ## Updated | |||
| - [#878](https://github.com/plotly/dash-core-components/pull/878) | |||
| - used the `getTooltipContainter` prop of dcc.Slider to make sure tooltips are positioned correctly when the parent slider is not visible due to it being in a HTML element with an `overflow-x` style, fixing [#751](https://github.com/plotly/dash-core-components/issues/751) | |||
There was a problem hiding this comment.
I think I missed the wrong level of details of https://github.com/plotly/dash-core-components/blame/dev/CHANGELOG.md#L26 which you are using as your baseline.
Make the entry more focused on what this fixes for the user. Something along the lines of:
Fix a bug causing the dcc.Slider and dcc.RangerSlider tooltip to be visible even if the component isn't visible (e.g. overflow)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #751