Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change names of our bundles #384

Closed
chriddyp opened this issue Sep 12, 2018 · 2 comments

Comments

2 participants
@chriddyp
Copy link
Member

commented Sep 12, 2018

Right now, we name all of our bundles bundle.js. We should rename these bundles the name of the JS library to make debugging / inspecting errors in the console easier. That is, across:

These changes can happen in the individual component libraries, e.g. here: https://github.com/plotly/dash-core-components/blob/29d9f1d366b64a2759fbfc74d184a0561288284d/dash_core_components/__init__.py#L42-L47
we shouldn't need to change anything in dash itself. I'm creating this issue in dash just to organize things across the repos 😺

@T4rk1n

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2018

@chriddyp

Should I do it in the serve dev bundle PRs while I'm at it ?

@chriddyp

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2018

@T4rk1n - Yup, that works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.