Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename long callbacks to background. #2116

Merged
merged 7 commits into from Jul 7, 2022
Merged

Rename long callbacks to background. #2116

merged 7 commits into from Jul 7, 2022

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Jul 4, 2022

  • Rename long argument to background
  • Remove long prefixes.
  • Deprecate
    • dash.long_callback.managers.CeleryLongCallbackManager -> dash.CeleryManager
    • dash.long_callback.managers.DiskcacheLongCallbackManager -> dash.DiskcacheManager
    • long_callback_manager dash constructor argument -> background_callback_manager

@T4rk1n T4rk1n requested a review from alexcjohnson as a code owner July 4, 2022 18:43
alexcjohnson
alexcjohnson approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@T4rk1n T4rk1n merged commit f698058 into dev Jul 7, 2022
@T4rk1n T4rk1n deleted the long-to-background branch July 7, 2022 13:37
@etpinard etpinard mentioned this pull request Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@T4rk1n @alexcjohnson