mssql: fix issues #299 #409 #462 #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `yarn docker:mssql:start` launches a local mssql server on port 1433 with user `sa` and password `yourStrong(!)Password`.
* Ensured database, schema and table names are surrounded by quotes. * Ensured table names include the schema name. Fixes plotly#299 Fixes plotly#409 Fixes plotly#462
n-riesco
force-pushed
the
mssql/fix-299-409-462
branch
from
a8208b2
to
d8de690
Compare
|
Hi @kndungu , would you be available to review this PR? |
|
Hi @n-riesco, certainly. Will do so in the next 24 hours, I need to go through the issues to make sure the PR fully addresses them. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.