Offline viewer should always be a function

plotly · Aug 26, 2015 · 4969d70 · 4969d70
1 parent fed7b10
commit 4969d70
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/R/offline.R b/R/offline.R
@@ -114,6 +114,6 @@ get_browser <- function() {
   # default web browser
   if (is.null(browseR) || !is.function(browseR) ||
       inherits(try(browseR('http://www.rstudio.com'), silent = TRUE), 'try-error'))
-    browseR = getOption("browser")
+    browseR = browseURL
   browseR
 }
diff --git a/R/print.R b/R/print.R
@@ -62,7 +62,7 @@ print.offline <- function(x, ...) {
   }
   index <- file.path(d, "index.html")
   res <- writeLines(html, index)
-  if (!is.null(x$viewer)) x$viewer(index)
+  if (is.function(x$viewer)) x$viewer(index)
 }
 
 #' Embed a plotly iframe into an R markdown document via \code{knit_print}