Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar axis autorange fix #2050

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
2 participants
@alexcjohnson
Copy link
Contributor

commented Oct 2, 2017

fixes #2049 - cleaner handling of base and zero for bar axis autorange.

We don't need to include 0 explicitly in the autorange for bars (unless we're normalizing), nor should we be including the bar base unless that was explicitly specified.

Most of the time these extras were just redundant, but for bars on date axes (which is not really a kosher use of bars but we don't forbid it) the zero (1970) is arbitrary and it's confusing and useless if this gets included in the autorange.

cc @etpinard

@etpinard

This comment has been minimized.

Copy link
Member

commented Oct 3, 2017

Looks good 💃

Thanks 🎉

@alexcjohnson alexcjohnson merged commit a1a68fb into master Oct 3, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@alexcjohnson alexcjohnson deleted the date-bars-autorange branch Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.