Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian translation #2632

Merged
merged 3 commits into from May 16, 2018

Conversation

Projects
None yet
3 participants
@ghtmtt
Copy link
Contributor

commented May 14, 2018

Thanks for your interest in plotly.js!

Italian translation for plotly. Not complete (yet)

@alexcjohnson

This comment has been minimized.

Copy link
Contributor

commented May 14, 2018

Thanks @ghtmtt - looks like you're almost there! Comparing with https://github.com/plotly/plotly.js/blob/master/dist/translation-keys.txt there are just a few more to add. Can you suggest one or two other Italian speakers to review once the last items are added?

@ghtmtt

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2018

@alexcjohnson here we go. All the translations should be updated now

Fix punctuation in it.js
Keys must match input keys exactly, and trailing colons should be preserved in the translation.
Also tweaked a couple of the comments to point to the right files
(note it's also fine to omit these comments entirely from the translation files,
as the file dist/translation-keys.txt always has up-to-date line references
as of the latest release)
@alexcjohnson

This comment has been minimized.

Copy link
Contributor

commented May 15, 2018

Great! I just tweaked a little of the punctuation and code reference comments. Perhaps I can convince @giulioungaretti to give a quick review of these translations? 🙏

@giulioungaretti

This comment has been minimized.

Copy link

commented May 16, 2018

@alexcjohnson the translation looks spot on!

@alexcjohnson

This comment has been minimized.

Copy link
Contributor

commented May 16, 2018

Thanks @giulioungaretti ! And thank you @ghtmtt for your contribution! 💃

@alexcjohnson alexcjohnson merged commit 42cc18d into plotly:master May 16, 2018

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details
@ghtmtt

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2018

I'm using plotly in my https://github.com/ghtmtt/DataPlotly plugin. That's the minimum I can do for you guys ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.