Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup bartext removal in update selections #2689

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@etpinard
Copy link
Member

commented Jun 1, 2018

fixes #2688 which was a regression since commit 6d88255 where all Bar started using a d3-iomatic update pattern.

cc @alexcjohnson

rm bartext element (if any) in update selection
... when tx item is blank or textposition is 'none'
@alexcjohnson

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2018

That was quick! Looks great 💃

@etpinard etpinard merged commit da193d7 into master Jun 4, 2018

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details

@etpinard etpinard deleted the fixup-bar-text-removal branch Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.