New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated fullLayout._size in scene.clear #2801

Merged
merged 1 commit into from Jul 10, 2018

Conversation

Projects
None yet
2 participants
@etpinard
Member

etpinard commented Jul 10, 2018

fixes #2731

Such that after relayout edits that do not trigger a recalc, selection can properly clear the canvas.

cc @alexcjohnson @dy

fix #2731 - use updated fullLayout._size in scene.clear
- such that after relayout edits that do not trigger a recalc,
  selection can properly clear the canvas.
@alexcjohnson

This comment has been minimized.

Show comment
Hide comment
@alexcjohnson

alexcjohnson Jul 10, 2018

Contributor

Nice find, beautiful test! 💃

Contributor

alexcjohnson commented Jul 10, 2018

Nice find, beautiful test! 💃

@etpinard etpinard merged commit 5cfc6b1 into master Jul 10, 2018

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details

@etpinard etpinard deleted the scattergl-select-after-resize-fix branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment