Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set camera mode to turntable when up.z is zero #3465

Merged
merged 2 commits into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@archmoj
Copy link
Collaborator

commented Jan 23, 2019

Fixes #3425 by not defaulting to turntable when camera.up.z is set to zero.
@etpinard

@etpinard

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

Thank you! 💃

@archmoj

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 23, 2019

@etpinard Thanks for the review.

@archmoj archmoj merged commit 1aa6c85 into master Jan 23, 2019

8 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: publish Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@archmoj archmoj deleted the fix3425-camera-change branch Jan 23, 2019

@etpinard

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

@archmoj This PR made

image

fail. Would mind taking a 👁 at this?

Running

npm run test-jasmine -- plot_api_react

should be enough to replicate the failure.

@archmoj

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 24, 2019

OK. I am working on it.

@archmoj

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 24, 2019

To pass this test this line should not have a z value equal to zero:

layout.scene.camera = {up: {x: 1, y: -1, z: 0}};

We may try layout.scene.camera = {up: {x: 1, y: 0, z: -1}}; instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.