Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsive WebGL figures and modebar #3500

Merged
merged 3 commits into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@antoinerg
Copy link
Collaborator

commented Jan 31, 2019

Closes #3485 and #3499

Codepen showing the fix: https://codepen.io/antoinerg/pen/bzgeod

How it behaves:

This PR might be easier to review commit by commit!

@etpinard

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

@antoinerg very nice PR. Thanks for rebasing those commits!

Have you had the chance to test this branch in IE11?

@antoinerg

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 13, 2019

Github gives a warning about using IE11. Codepen just plain doesn't work with IE11. plotly.js deserves a compatibility award for even trying 🏆

On a more serious note though, IE11 has issue with flexbox columns and right now a vertical modebar will overflow:
screenshot_2019-02-12_20-06-14

I'm tempted to open a separate issue for responsive modebar in IE11 since this unwanted behavior is not introduced by the current PR. Also, I don't know if it will be easy or even possible to make the modebar span multiple columns in IE11 using HTML/CSS: I don't want to block the improvements from this PR from getting merged in (in particular it fixes nasty #3485).

Let me know what you think and thanks for reviewing this!

@etpinard

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Codepen just plain doesn't work with IE11

Yeah, I usually use our npm start test dashboard together with browserstack localhost wizardry to test IE11

I'm tempted to open a separate issue for responsive modebar in IE11 since this unwanted behavior is not introduced by the current PR.

Sure!

I don't want to block the improvements from this PR from getting merged in (in particular it fixes nasty #3485).

Good call!


💃 💃 💃

@antoinerg antoinerg merged commit b03bb3b into master Feb 13, 2019

8 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: publish Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@antoinerg antoinerg deleted the pr-responsive-gl-modebar branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.