Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix waterfall hovermode closest decreasing values #3778

Merged
merged 3 commits into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@archmoj
Copy link
Collaborator

commented Apr 16, 2019

@@ -34,6 +34,7 @@ function hoverOnBars(pointData, xval, yval, hovermode) {
var trace = cd[0].trace;
var t = cd[0].t;
var isClosest = (hovermode === 'closest');
var isWaterfall = (trace.type === 'waterfall');

This comment has been minimized.

Copy link
@etpinard

etpinard Apr 16, 2019

Member

Hmm. I guess it would be annoying to move this logic in waterfall/hover.js. 😞

@etpinard

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Thanks for the fix and test 💃

@archmoj archmoj merged commit 172c3e6 into master Apr 16, 2019

10 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: publish Your tests passed on CircleCI!
Details
ci/circleci: test-bundle Your tests passed on CircleCI!
Details
ci/circleci: test-image Your tests passed on CircleCI!
Details
ci/circleci: test-image2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine2 Your tests passed on CircleCI!
Details
ci/circleci: test-jasmine3 Your tests passed on CircleCI!
Details
ci/circleci: test-syntax Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@archmoj archmoj deleted the fix3776-waterfall-hovermode-closest branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.