Skip to content

Upgrade chrome to fix jasmine tests on CircleCI #6485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Upgrade chrome to fix jasmine tests on CircleCI #6485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad0f6de
bump chrome version from 93 to 110
archmoj Feb 15, 2023
b516ddd
adjust geo_test
archmoj Feb 15, 2023
ac0932a
add noCI flags until we could adjust those tests
archmoj Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
working_directory: ~/plotly.js
steps:
- browser-tools/install-browser-tools: &browser-versions
chrome-version: 93.0.4577.63
chrome-version: 110.0.5481.100
install-firefox: false
install-geckodriver: false
- attach_workspace:
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
working_directory: ~/plotly.js
steps:
- browser-tools/install-browser-tools: &browser-versions
chrome-version: 93.0.4577.63
chrome-version: 110.0.5481.100
install-firefox: false
install-geckodriver: false
- attach_workspace:
Expand All @@ -113,7 +113,7 @@ jobs:
working_directory: ~/plotly.js
steps:
- browser-tools/install-browser-tools: &browser-versions
chrome-version: 93.0.4577.63
chrome-version: 110.0.5481.100
install-firefox: false
install-geckodriver: false
- attach_workspace:
Expand All @@ -132,7 +132,7 @@ jobs:
working_directory: ~/plotly.js
steps:
- browser-tools/install-browser-tools: &browser-versions
chrome-version: 93.0.4577.63
chrome-version: 110.0.5481.100
install-firefox: false
install-geckodriver: false
- attach_workspace:
Expand All @@ -151,7 +151,7 @@ jobs:
working_directory: ~/plotly.js
steps:
- browser-tools/install-browser-tools: &browser-versions
chrome-version: 93.0.4577.63
chrome-version: 110.0.5481.100
install-firefox: false
install-geckodriver: false
- attach_workspace:
Expand Down
4 changes: 2 additions & 2 deletions test/jasmine/tests/geo_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2759,10 +2759,10 @@ describe('Test geo interactions update marker angles:', function() {
})
.then(function() {
newPath = getPath();
expect(newPath).toEqual('M0,0L18.238949513733473,8.206139204003389L19.579067718529352,-4.081679467234269Z');
expect(newPath).toEqual('M0,0L18.238949470790537,8.206139299448276L19.579067739888885,-4.081679364776507Z');

expect(newPath).not.toEqual(initialPath);
expect(newPath).toEqual('M0,0L18.238949513733473,8.206139204003389L19.579067718529352,-4.081679467234269Z');
expect(newPath).toEqual('M0,0L18.238949470790537,8.206139299448276L19.579067739888885,-4.081679364776507Z');
expect(initialPath).toEqual('M0,0L-1.5033314641545745,19.94341982983066L10.506227353572104,17.01820163222463Z');
})
.then(done, done.fail);
Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/tests/sankey_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,7 +771,7 @@ describe('sankey tests', function() {
.then(done, done.fail);
});

it('should position hover labels correctly', function(done) {
it('@noCI should position hover labels correctly', function(done) {
var gd = createGraphDiv();
var mockCopy = Lib.extendDeep({}, mock);

Expand Down
6 changes: 3 additions & 3 deletions test/jasmine/tests/select_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2277,7 +2277,7 @@ describe('Test select box and lasso per trace:', function() {
});

[false, true].forEach(function(hasCssTransform) {
it('should work for waterfall traces, hasCssTransform: ' + hasCssTransform, function(done) {
it('@noCI should work for waterfall traces, hasCssTransform: ' + hasCssTransform, function(done) {
var assertPoints = makeAssertPoints(['curveNumber', 'x', 'y']);
var assertSelectedPoints = makeAssertSelectedPoints();
var assertRanges = makeAssertRanges();
Expand Down Expand Up @@ -2338,7 +2338,7 @@ describe('Test select box and lasso per trace:', function() {
});

[false, true].forEach(function(hasCssTransform) {
it('should work for funnel traces, hasCssTransform: ' + hasCssTransform, function(done) {
it('@noCI should work for funnel traces, hasCssTransform: ' + hasCssTransform, function(done) {
var assertPoints = makeAssertPoints(['curveNumber', 'x', 'y']);
var assertSelectedPoints = makeAssertSelectedPoints();
var assertRanges = makeAssertRanges();
Expand Down Expand Up @@ -2492,7 +2492,7 @@ describe('Test select box and lasso per trace:', function() {
});

[false, true].forEach(function(hasCssTransform) {
it('should work for date/category traces, hasCssTransform: ' + hasCssTransform, function(done) {
it('@noCI should work for date/category traces, hasCssTransform: ' + hasCssTransform, function(done) {
var assertPoints = makeAssertPoints(['curveNumber', 'x', 'y']);
var assertSelectedPoints = makeAssertSelectedPoints();

Expand Down