New eslint rules #925
Merged
New eslint rules #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this was only violated once in drawing (fixed in this commit)
- exclude MathJax.<> calls - exclude in micropolar module
Contributor
Author
|
Rules
require a little more work to enforce than I want to do right now. Leaving this for future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a few eslint rules to the
.eslintrcthat we are already mostly respecting.In this PR, I'm also hoping to enforce:
"no-shadow": [2, {"builtinGlobals": true}]- doc"consistent-this": [2, "self"]- doc"spaced-comment": [2, "always"]- docIf anyone has an objection to ⏫ , please let me know!