From 738065eb5c1bc643e349ceb2bfcd5efe7c86b2b4 Mon Sep 17 00:00:00 2001 From: alishobeiri Date: Fri, 23 Jun 2017 13:16:22 -0400 Subject: [PATCH 1/5] Changed integer based indexing to location based index Now selects first element in series rather than 0th element - old way could cause problems when the dataframe being drawn doesn't start at index 0 and starts at a higher number. Happened to me :P --- plotly/figure_factory/_facet_grid.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plotly/figure_factory/_facet_grid.py b/plotly/figure_factory/_facet_grid.py index cc517cfb61..6b33bdcb9d 100644 --- a/plotly/figure_factory/_facet_grid.py +++ b/plotly/figure_factory/_facet_grid.py @@ -783,7 +783,7 @@ def create_facet_grid(df, x, y, facet_row=None, facet_col=None, ) show_legend = False if color_name: - if isinstance(df[color_name][0], str) or color_is_cat: + if isinstance(df[color_name].iloc[0], str) or color_is_cat: show_legend = True if isinstance(colormap, dict): utils.validate_colors_dict(colormap, 'rgb') From 42c0d996277a17e1c5167961890c4798c7b84b84 Mon Sep 17 00:00:00 2001 From: alishobeiri Date: Fri, 23 Jun 2017 13:58:35 -0400 Subject: [PATCH 2/5] Update _facet_grid.py I was getting error that kwargs is undefined: ```NameError Traceback (most recent call last) in () 9 facet_row='cut', 10 color_name='depth', ---> 11 facet_col='z' 12 13 ) /home/alishobeiri/anaconda2/lib/python2.7/site-packages/plotly/figure_factory/_facet_grid.pyc in create_facet_grid(df, x, y, facet_row, facet_col, color_name, colormap, color_is_cat, facet_row_labels, facet_col_labels, height, width, trace_type, scales, dtick_x, dtick_y, show_boxes, ggplot2, binsize, **kwargs) 867 facet_row_labels, facet_col_labels, trace_type, 868 flipped_rows, flipped_cols, show_boxes, marker_color, --> 869 kwargs_trace, kwargs_marker 870 ) 871 /home/alishobeiri/anaconda2/lib/python2.7/site-packages/plotly/figure_factory/_facet_grid.pyc in _facet_grid_color_numerical(df, x, y, facet_row, facet_col, color_name, colormap, num_of_rows, num_of_cols, facet_row_labels, facet_col_labels, trace_type, flipped_rows, flipped_cols, show_boxes, marker_color, kwargs_trace, kwargs_marker) 414 type=trace_type, 415 showlegend=False, --> 416 **kwargs 417 ) 418 fig.append_trace(trace, row_count + 1, col_count + 1) NameError: global name 'kwargs' is not defined ``` Thought it might be because kwargs should actually be kwards_trace - not sure tho --- plotly/figure_factory/_facet_grid.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plotly/figure_factory/_facet_grid.py b/plotly/figure_factory/_facet_grid.py index 6b33bdcb9d..168552f0eb 100644 --- a/plotly/figure_factory/_facet_grid.py +++ b/plotly/figure_factory/_facet_grid.py @@ -413,7 +413,7 @@ def _facet_grid_color_numerical(df, x, y, facet_row, facet_col, color_name, mode='markers', type=trace_type, showlegend=False, - **kwargs + **kwargs_trace ) fig.append_trace(trace, row_count + 1, col_count + 1) if row_count == 0: From b0da3c6e249a9f3fe290d19153f5cf2b4308a984 Mon Sep 17 00:00:00 2001 From: alishobeiri Date: Fri, 23 Jun 2017 15:09:39 -0400 Subject: [PATCH 3/5] Reverted commit that was wrong --- plotly/figure_factory/_facet_grid.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plotly/figure_factory/_facet_grid.py b/plotly/figure_factory/_facet_grid.py index 168552f0eb..6b33bdcb9d 100644 --- a/plotly/figure_factory/_facet_grid.py +++ b/plotly/figure_factory/_facet_grid.py @@ -413,7 +413,7 @@ def _facet_grid_color_numerical(df, x, y, facet_row, facet_col, color_name, mode='markers', type=trace_type, showlegend=False, - **kwargs_trace + **kwargs ) fig.append_trace(trace, row_count + 1, col_count + 1) if row_count == 0: From 76d9d174791dcd49af6964c4604680553b1c23a4 Mon Sep 17 00:00:00 2001 From: alishobeiri Date: Mon, 26 Jun 2017 11:35:58 -0400 Subject: [PATCH 4/5] kwargs is undefined, I think it should be kwargs_trace --- plotly/figure_factory/_facet_grid.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plotly/figure_factory/_facet_grid.py b/plotly/figure_factory/_facet_grid.py index 6b33bdcb9d..168552f0eb 100644 --- a/plotly/figure_factory/_facet_grid.py +++ b/plotly/figure_factory/_facet_grid.py @@ -413,7 +413,7 @@ def _facet_grid_color_numerical(df, x, y, facet_row, facet_col, color_name, mode='markers', type=trace_type, showlegend=False, - **kwargs + **kwargs_trace ) fig.append_trace(trace, row_count + 1, col_count + 1) if row_count == 0: From fb39dfeafe1592659023171d76eb99885c69ec27 Mon Sep 17 00:00:00 2001 From: alishobeiri Date: Mon, 26 Jun 2017 16:50:05 -0400 Subject: [PATCH 5/5] Update _facet_grid.py --- plotly/figure_factory/_facet_grid.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plotly/figure_factory/_facet_grid.py b/plotly/figure_factory/_facet_grid.py index 168552f0eb..d0f401ecb1 100644 --- a/plotly/figure_factory/_facet_grid.py +++ b/plotly/figure_factory/_facet_grid.py @@ -812,7 +812,7 @@ def create_facet_grid(df, x, y, facet_row=None, facet_col=None, marker_color, kwargs_trace, kwargs_marker ) - elif isinstance(df[color_name][0], Number): + elif isinstance(df[color_name].iloc[0], Number): if isinstance(colormap, dict): show_legend = True utils.validate_colors_dict(colormap, 'rgb')