From d779826ac1fb2e641b463459fe29c42ba5678f09 Mon Sep 17 00:00:00 2001
From: Nicolas Kruchten <nicolas@datacratic.com>
Date: Thu, 6 Sep 2018 12:43:09 -0400
Subject: [PATCH] patches for creating cones and tubes from scratch

---
 src/default_panels/GraphCreatePanel.js |  3 +++
 src/default_panels/StyleTracesPanel.js | 20 ++++++++++++++++++++
 src/lib/customTraceType.js             |  5 +++++
 3 files changed, 28 insertions(+)

diff --git a/src/default_panels/GraphCreatePanel.js b/src/default_panels/GraphCreatePanel.js
index fc9e2c41a..5eb8f894f 100644
--- a/src/default_panels/GraphCreatePanel.js
+++ b/src/default_panels/GraphCreatePanel.js
@@ -102,6 +102,9 @@ const GraphCreatePanel = (props, {localize: _, setPanel}) => {
       <DataSelector label={_('U')} attr="u" />
       <DataSelector label={_('V')} attr="v" />
       <DataSelector label={_('W')} attr="w" />
+      <DataSelector label={_('X start')} attr="starts.x" />
+      <DataSelector label={_('Y start')} attr="starts.y" />
+      <DataSelector label={_('Z start')} attr="starts.z" />
       <DataSelector label={_('Headers')} attr="header.values" />
       <DataSelector label={_('Columns')} attr="cells.values" />
 
diff --git a/src/default_panels/StyleTracesPanel.js b/src/default_panels/StyleTracesPanel.js
index dda018fa9..4576c38f4 100644
--- a/src/default_panels/StyleTracesPanel.js
+++ b/src/default_panels/StyleTracesPanel.js
@@ -49,6 +49,25 @@ const StyleTracesPanel = (props, {localize: _}) => (
       options={[{label: _('Show'), value: true}, {label: _('Hide'), value: false}]}
     />
     <NumericFraction label={_('Trace Opacity')} attr="opacity" />
+    <PlotlySection name={_('Cones & Streamtubes')}>
+      <Numeric label={_('Size')} attr="sizeref" />
+      <Dropdown
+        label={_('Size Mode')}
+        options={[{label: _('scaled'), value: 'scaled'}, {label: _('absolute'), value: 'absolute'}]}
+        attr="sizemode"
+      />
+      <Dropdown
+        label={_('Cone Anchor')}
+        options={[
+          {label: _('Tip'), value: 'tip'},
+          {label: _('Tail'), value: 'tail'},
+          {label: _('Center'), value: 'center'},
+          {label: _('Center of Mass'), value: 'cm'},
+        ]}
+        attr="anchor"
+      />
+      <Numeric label={_('Max Tube segments')} attr="maxdisplayed" />
+    </PlotlySection>
     <MultiColorPicker label={_('Color')} attr="color" />
     <TraceTypeSection name={_('Pie Colors')} traceTypes={['pie']} mode="trace">
       <LayoutSection attr="name">
@@ -222,6 +241,7 @@ const StyleTracesPanel = (props, {localize: _}) => (
       <SymbolSelector label={_('Symbol')} attr="marker.symbol" />
       <Numeric label={_('Border Width')} attr="marker.line.width" />
       <MultiColorPicker label={_('Border Color')} attr="marker.line.color" />
+      <Numeric label={_('Max Number of Points')} attr="marker.maxdisplayed" />
     </TraceMarkerSection>
 
     <TraceTypeSection
diff --git a/src/lib/customTraceType.js b/src/lib/customTraceType.js
index 9b2a8b684..5047c2f24 100644
--- a/src/lib/customTraceType.js
+++ b/src/lib/customTraceType.js
@@ -92,6 +92,11 @@ export function traceTypeToPlotlyInitFigure(traceType, gl = '') {
         orientation: 'v',
         type: 'bar',
       };
+    case 'cone':
+      return {
+        sizeref: 1,
+        type: 'cone',
+      };
     default:
       return {type: traceType};
   }