From 728fcf99eed54b0fb4add491d9cf39246ae8c1d7 Mon Sep 17 00:00:00 2001 From: Nicolas Kruchten Date: Fri, 19 Oct 2018 10:48:37 -0400 Subject: [PATCH 1/2] preset sizeref reasonably --- src/EditorControls.js | 2 ++ src/default_panels/StyleTracesPanel.js | 2 +- src/shame.js | 10 ++++++++++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/EditorControls.js b/src/EditorControls.js index 8ddad4e5a..97e3dcc66 100644 --- a/src/EditorControls.js +++ b/src/EditorControls.js @@ -10,6 +10,7 @@ import { shamefullyCreateSplitStyleProps, shamefullyAdjustSplitStyleTargetContainers, shamefullyDeleteRelatedAnalysisTransforms, + shamefullyAdjustSizeref, } from './shame'; import {EDITOR_ACTIONS} from './lib/constants'; import isNumeric from 'fast-isnumeric'; @@ -70,6 +71,7 @@ class EditorControls extends Component { this.props.beforeUpdateTraces(payload); } + shamefullyAdjustSizeref(graphDiv, payload); shamefullyClearAxisTypes(graphDiv, payload); shamefullyAdjustAxisRef(graphDiv, payload); shamefullyAddTableColumns(graphDiv, payload); diff --git a/src/default_panels/StyleTracesPanel.js b/src/default_panels/StyleTracesPanel.js index f0a670f2f..f1ff4f740 100644 --- a/src/default_panels/StyleTracesPanel.js +++ b/src/default_panels/StyleTracesPanel.js @@ -246,7 +246,7 @@ const StyleTracesPanel = (props, {localize: _}) => ( diff --git a/src/shame.js b/src/shame.js index e12e55795..14b6fcecd 100644 --- a/src/shame.js +++ b/src/shame.js @@ -202,3 +202,13 @@ export const shamefullyDeleteRelatedAnalysisTransforms = (graphDiv, payload) => } } }; + +export const shamefullyAdjustSizeref = (gd, {update}) => { + const {'marker.size': size = null, 'marker.sizesrc': src = null} = update; + if (size && src) { + const DEFAULT_MAX_AREA_PX = 45; + const scaleFactor = DEFAULT_MAX_AREA_PX * DEFAULT_MAX_AREA_PX; + update['marker.sizeref'] = size.reduce((a, b) => Math.max(a, b)) / scaleFactor; + update['marker.sizemode'] = 'area'; + } +}; From 9fb53c717be44cf514f3be198a72f1f0fe2a0e47 Mon Sep 17 00:00:00 2001 From: Nicolas Kruchten Date: Fri, 19 Oct 2018 11:03:25 -0400 Subject: [PATCH 2/2] version bump --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 158736073..78e05bfc0 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "react-chart-editor", "description": "plotly.js chart editor react component UI", - "version": "0.32.0", + "version": "0.32.1", "author": "Plotly, Inc.", "bugs": { "url": "https://github.com/plotly/react-chart-editor/issues"