Skip to content

Tweaks #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Tweaks #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8da803f
searchable data selectors, of course
nicolaskruchten Nov 5, 2018
df9d504
disable less when no traces exist
nicolaskruchten Nov 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/containers/AnnotationAccordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import PlotlyFold from './PlotlyFold';
import TraceRequiredPanel from './TraceRequiredPanel';
import {LayoutPanel} from './derived';
import {PanelMessage} from './PanelEmpty';
import PropTypes from 'prop-types';
import React, {Component} from 'react';
Expand Down Expand Up @@ -43,7 +43,7 @@ class AnnotationAccordion extends Component {
};

return (
<TraceRequiredPanel addAction={canAdd ? addAction : null}>
<LayoutPanel addAction={canAdd ? addAction : null}>
{content ? (
content
) : (
Expand All @@ -56,7 +56,7 @@ class AnnotationAccordion extends Component {
<p>{_('Click on the + button above to add an annotation.')}</p>
</PanelMessage>
)}
</TraceRequiredPanel>
</LayoutPanel>
);
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/components/containers/ImageAccordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import PlotlyFold from './PlotlyFold';
import TraceRequiredPanel from './TraceRequiredPanel';
import {LayoutPanel} from './derived';
import PropTypes from 'prop-types';
import React, {Component} from 'react';
import {connectImageToLayout} from 'lib';
Expand Down Expand Up @@ -48,7 +48,7 @@ class ImageAccordion extends Component {
};

return (
<TraceRequiredPanel addAction={canAdd ? addAction : null}>
<LayoutPanel addAction={canAdd ? addAction : null}>
{content ? (
content
) : (
Expand All @@ -61,7 +61,7 @@ class ImageAccordion extends Component {
<p>{_('Click on the + button above to add an image.')}</p>
</PanelMessage>
)}
</TraceRequiredPanel>
</LayoutPanel>
);
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/components/containers/ShapeAccordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import PlotlyFold from './PlotlyFold';
import TraceRequiredPanel from './TraceRequiredPanel';
import {LayoutPanel} from './derived';
import PropTypes from 'prop-types';
import React, {Component} from 'react';
import {connectShapeToLayout} from 'lib';
Expand Down Expand Up @@ -48,7 +48,7 @@ class ShapeAccordion extends Component {
};

return (
<TraceRequiredPanel addAction={canAdd ? addAction : null}>
<LayoutPanel addAction={canAdd ? addAction : null}>
{content ? (
content
) : (
Expand All @@ -61,7 +61,7 @@ class ShapeAccordion extends Component {
<p>{_('Click on the + button above to add a shape.')}</p>
</PanelMessage>
)}
</TraceRequiredPanel>
</LayoutPanel>
);
}
}
Expand Down
1 change: 1 addition & 0 deletions src/components/fields/DataSelector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ export class UnconnectedDataSelector extends Component {
value={this.fullValue}
onChange={this.updatePlot}
multi={this.is2D}
searchable={true}
Copy link
Contributor

@VeraZab VeraZab Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as easy as that hein! nice!

optionRenderer={this.context.dataSourceOptionRenderer}
valueRenderer={this.context.dataSourceValueRenderer}
clearable={true}
Expand Down
6 changes: 3 additions & 3 deletions src/default_panels/StyleAxesPanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
Radio,
TextEditor,
PlotlySection,
TraceRequiredPanel,
LayoutPanel,
AxesFold,
AxisSide,
RangesliderVisible,
Expand All @@ -26,7 +26,7 @@ class StyleAxesPanel extends Component {
render() {
const {localize: _} = this.context;
return (
<TraceRequiredPanel>
<LayoutPanel>
<AxesFold
name={_('Titles')}
axisFilter={axis => !(axis._name.includes('angular') || axis._subplot.includes('geo'))}
Expand Down Expand Up @@ -402,7 +402,7 @@ class StyleAxesPanel extends Component {
<Numeric label={_('Thickness')} attr="spikethickness" units="px" />
<ColorPicker label={_('Color')} attr="spikecolor" />
</AxesFold>
</TraceRequiredPanel>
</LayoutPanel>
);
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/default_panels/StyleLayoutPanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
Numeric,
TextEditor,
PlotlySection,
TraceRequiredPanel,
LayoutPanel,
VisibilitySelect,
HovermodeDropdown,
Flaglist,
Expand All @@ -18,7 +18,7 @@ import {
import {HoverColor} from '../components/fields/derived';

const StyleLayoutPanel = (props, {localize: _}) => (
<TraceRequiredPanel>
<LayoutPanel>
<PlotlyFold name={_('Defaults')}>
<ColorPicker label={_('Plot Background')} attr="plot_bgcolor" />
<ColorPicker label={_('Margin Color')} attr="paper_bgcolor" />
Expand Down Expand Up @@ -137,7 +137,7 @@ const StyleLayoutPanel = (props, {localize: _}) => (
</HovermodeDropdown>
</PlotlySection>
</PlotlyFold>
</TraceRequiredPanel>
</LayoutPanel>
);

StyleLayoutPanel.contextTypes = {
Expand Down