feat(pie): fix typings

plouc · Nov 20, 2023 · a1a774d · a1a774d
1 parent 238e8d1
commit a1a774d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/packages/pie/src/PieCanvas.tsx b/packages/pie/src/PieCanvas.tsx
@@ -205,6 +205,7 @@ const InnerPieCanvas = <RawDatum extends MayHaveLabel>({
         centerY,
         arcGenerator,
         dataWithArc,
+        borderWidth,
         getBorderColor,
         enableArcLabels,
         arcLabels,

diff --git a/packages/pie/src/hooks.ts b/packages/pie/src/hooks.ts
@@ -368,7 +368,7 @@ export const usePieFromBox = <RawDatum>({
             innerRadius,
             debug: boundingBox,
         }
-    }, [width, height, innerRadiusRatio, startAngle, endAngle, fit, cornerRadius])
+    }, [width, height, innerRadiusRatio, startAngle, endAngle, fit])
 
     const pieArcs = usePieArcs({
         data,

diff --git a/packages/pie/src/types.ts b/packages/pie/src/types.ts
@@ -28,7 +28,7 @@ export interface DefaultRawDatum {
     value: number
 }
 
-export interface MayHaveLabel {
+export interface MayHaveLabel extends Object {
     label?: string | number
 }
 

diff --git a/packages/pie/tests/Pie.test.tsx b/packages/pie/tests/Pie.test.tsx
@@ -12,7 +12,13 @@ import { LegendSvgItem, SymbolSquare } from '@nivo/legends'
 // @ts-ignore
 import { Pie } from '../src/index'
 
-const sampleData = [
+interface SampleDatum {
+    id: string
+    value: number
+    color: string
+}
+
+const sampleData: readonly SampleDatum[] = [
     {
         id: 'A',
         value: 30,