Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pie package #1204

Merged
merged 35 commits into from
Nov 4, 2020
Merged

Improve pie package #1204

merged 35 commits into from
Nov 4, 2020

Conversation

plouc
Copy link
Owner

@plouc plouc commented Nov 1, 2020

Updates/additions:

  • Remove the PieLayout component in favor of hooks.
  • Add support for layers.
  • Fix support for colors coming from the dataset.
  • Improve documentation.
  • Add proper unit tests.
  • Add the ability to handle custom datum via the id and value property accessors.
  • Add d3 formatting support for values.
  • Add support for mouse enter/move/leave handlers.
  • Honor isInteractive property, removing handlers when disabled.

Resolves the following issues:

@plouc plouc added 🍰 pie @nivo/pie package nivo core team labels Nov 1, 2020
@plouc plouc self-assigned this Nov 1, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7ca62e8:

Sandbox Source
nivo Configuration
nivo-website Configuration

@plouc plouc marked this pull request as ready for review November 4, 2020 09:24
@plouc plouc merged commit 0335b6d into master Nov 4, 2020
@plouc plouc deleted the improve-pie branch November 4, 2020 09:57
@wyze
Copy link
Contributor

wyze commented Nov 4, 2020

Boom! 💥 Awesome work @plouc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants