Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more than one digit versions in Makefile #27

Merged
merged 1 commit into from Oct 8, 2017

Conversation

Projects
None yet
3 participants
@luisbosque
Copy link
Contributor

commented Jun 2, 2017

The string comparisson of PG versions was returning true to any
comparisson of 10 or any other greater version with 9.x or 8.4 versions.
Trying to compare separately major and minor versions in order to be
able to support more than one digit versions.

Also, parse non released versions with alpha, beta or rc suffixes.
Ignore the suffix and keep the numeric part.

Support more than one digit versions in Makefile
The string comparisson of PG versions was returning true to any
comparisson of 10 or any other greater version with 9.x or 8.4 versions.
Trying to compare separately major and minor versions in order to be
able to support more than one digit versions.

Also, parse non released versions with alpha, beta or rc suffixes.
Ignore the suffix and keep the numeric part.
@df7cb

This comment has been minimized.

Copy link

commented Sep 11, 2017

The PR title might not say it explicitly enough: This PR is required for supporting PostgreSQL 10.
Can we have it merged and a release tagged so packagers can update the distributions?
Thanks!

@markokr markokr merged commit c78407f into plproxy:master Oct 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.