New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPANTS fixes (PRC) #200

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@jjatria
Copy link
Contributor

jjatria commented Feb 10, 2018

This fixes two remaining CPANTS issues. There is one issue remaining after this, about Test::Pod not being declared as a test requirement. But I imagine this is an issue with the PodSyntaxTests plugin rather than with Pithub itself.

This PR brought to you by the CPAN PRC!

Fix pending CPANTS issues
* Add URI to list of required modules
* Declare minimum perl in meta
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 10, 2018

Coverage Status

Coverage remained the same at 99.013% when pulling f73f284 on jjatria:cpants-fixes into ad4c3ba on plu:master.

3 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 10, 2018

Coverage Status

Coverage remained the same at 99.013% when pulling f73f284 on jjatria:cpants-fixes into ad4c3ba on plu:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 10, 2018

Coverage Status

Coverage remained the same at 99.013% when pulling f73f284 on jjatria:cpants-fixes into ad4c3ba on plu:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 10, 2018

Coverage Status

Coverage remained the same at 99.013% when pulling f73f284 on jjatria:cpants-fixes into ad4c3ba on plu:master.

@oalders

This comment has been minimized.

Copy link
Collaborator

oalders commented Feb 15, 2018

@jjatria I think this should actually be fixed in master now. I saw the failing tests and updated our dzil configuration. Can you confirm whether we still need this PR?

@jjatria

This comment has been minimized.

Copy link
Contributor

jjatria commented Feb 15, 2018

Nope, seems like you beat me to it. Closing!

@jjatria jjatria closed this Feb 15, 2018

@jjatria jjatria deleted the jjatria:cpants-fixes branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment