Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rate_limit method to base #204

Merged
merged 1 commit into from Feb 16, 2018
Merged

Add a rate_limit method to base #204

merged 1 commit into from Feb 16, 2018

Conversation

@jjatria
Copy link
Contributor

@jjatria jjatria commented Feb 15, 2018

This implements the changes discussed in #202 to make it possible for all Pithub objects to check the current rate limit for whatever authentication method they are using.

@coveralls
Copy link

@coveralls coveralls commented Feb 15, 2018

Coverage Status

Coverage decreased (-0.08%) to 98.995% when pulling c6e84c8 on jjatria:feat-rate-limit into 6ec66c3 on plu:master.

@oalders
Copy link
Collaborator

@oalders oalders commented Feb 15, 2018

LGTM. @plu what do you think?

@plu
Copy link
Owner

@plu plu commented Feb 16, 2018

Looks great, thank you 👍

@plu plu merged commit 4ff8b38 into plu:master Feb 16, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jjatria jjatria deleted the jjatria:feat-rate-limit branch Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.