correct for-attribute, move secret-input down #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
get rid of the input-field. its useless. add a filter instead. |
|
put two filter in the |
schlessera
reviewed
Feb 4, 2017
antispam_bee.php
Outdated
| * @param int $post_id The post ID. | ||
| */ | ||
| return apply_filters( | ||
| 'get_secret_id_for_post', |
schlessera
reviewed
Feb 4, 2017
antispam_bee.php
Outdated
| * @param int $post_id The post ID. | ||
| */ | ||
| return apply_filters( | ||
| 'ab_get_secret_for_post', |
There was a problem hiding this comment.
Maybe add name in the filter?
|
refactored |
schlessera
reviewed
Feb 4, 2017
|
|
||
| // Hidden field check | ||
| if ( empty($hidden_field) && ! empty($plugin_field) ) { | ||
| $_POST['comment'] = $plugin_field; | ||
| unset( $_POST[ self::get_secret_for_post( $post_id ) ] ); | ||
| unset( $_POST[ self::get_secret_name_for_post( $post_id ) ] ); |
There was a problem hiding this comment.
Shouldn't this be unset( $plugin_field )?
There was a problem hiding this comment.
We could unset this too. But I think the general idea here is more get rid of the extra $_POST-field after the data has been transfered to $_POST['comment']
There was a problem hiding this comment.
Ah, nevermind, I misread the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #99