Fix(Core): Fix json_decode for 'itemtypes' field #1057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Fix :
Prevent error when decoding
itemtypeswith GLPI custom asset classesThe issue occurs when
fields['itemtypes']contains GLPI Custom Asset class names using namespaces, for example:In such cases,
json_decode()fails because unescaped backslashes make the JSON string invalid, returningnullinstead of an array.To ensure consistent decoding of
itemtypes, enforce the use of the following helper method:This ensures proper decoding of
itemtypeseven when they contain GLPI namespaced asset classes, avoidingin_array()runtime errors during template rendering.Fix migration for GenericObject itemtypes
The migration process for GenericObject types has been updated to correctly generate the corresponding GLPI Custom Asset class names using proper namespace escaping:
This ensures that migrated itemtypes reference the correct fully qualified class names (e.g.,
Glpi\\CustomAsset\\Car) and remain compatible withjson_decode()and Twig rendering.For instances that have already completed the migration prior to this fix, the correction must still be applied to maintain consistency and prevent runtime errors during template rendering.